Skip to content

Commit 368f7a1

Browse files
authored
chore(ci): fix CodSpeed working directory (#2732)
Hey, I am a co-founder at @CodSpeedHQ, really glad to have you use it! I checked out the repository after @hellovai contacted us, and found there were an improvement that could be made to the setup! ## Changes - bumped [`CodSpeedHQ/action`](https://github.com/CodSpeedHQ/action/) to v4 - used the `working-directory` input instead of using `cd` inside the `run` input Thanks to those changes, you will normally benefit from [automated profiling](https://codspeed.io/docs/instruments/walltime#automated-profiling) on your benchmarks! ## Additional Notes There is an issue with the benchmarks generated with https://github.com/BoundaryML/baml/blob/514afc9dcbccd692dd7c59f53f69b45169984524/baml_language/crates/baml_tests/benches/compiler_benchmark.rs#L319, their dashboard is not accessible because their URI is malformed (it contains the whole path, eg: `/actions-runner/_work/baml/baml/baml_language/target/release/build/baml_tests-74008be547e634ff/out/generated_benchmarks.rs::bench_incremental_add_attribute`). We will take a look to at least try to make their dashboard work.
1 parent 4c9d507 commit 368f7a1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -487,11 +487,12 @@ jobs:
487487
working-directory: baml_language
488488

489489
- name: "Run benchmarks"
490-
uses: CodSpeedHQ/action@v3
490+
uses: CodSpeedHQ/action@v4
491491
with:
492492
mode: walltime
493-
run: cd baml_language && cargo codspeed run
493+
run: cargo codspeed run
494494
token: ${{ secrets.CODSPEED_TOKEN }}
495+
working-directory: baml_language
495496

496497
test-summary:
497498
name: "Test Summary"

0 commit comments

Comments
 (0)