scripts: align update-cheatsheets.sh with update-cwe.sh style

- Replace SQLite online backup with a simple `cp` backup (matches update-cwe.sh)
- Remove stamp-file optimisation to keep unconditional pip install
- Keep environment variables to disable gap analysis and embeddings
- Keep link normalization to convert GitHub URLs to official HTML pages
- Ensure trailing newline at EOF

This addresses all points from PR review OWASP#952.

Author: Bornunique911

scripts/update-cheatsheets.sh

@@ -2,54 +2,34 @@
 set -euo pipefail
 
 ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
-DB_PATH="${1:-$ROOT_DIR/standards_cache.sqlite}"
 VENV_DIR="$ROOT_DIR/venv"
+CACHE_FILE="${1:-$ROOT_DIR/standards_cache.sqlite}"
+TIMESTAMP="$(date +%Y%m%d-%H%M%S)"
+BACKUP_FILE="${CACHE_FILE}.bak.${TIMESTAMP}"
 
-if [[ ! -x "$VENV_DIR/bin/python" ]]; then
+if [[ ! -d "$VENV_DIR" ]]; then
+  echo "Creating virtual environment in $VENV_DIR"
   python3 -m venv "$VENV_DIR"
 fi
 
 source "$VENV_DIR/bin/activate"
 
-# FIX: always install requirements to pick up new/updated packages
-"$VENV_DIR/bin/python" -m pip install -r "$ROOT_DIR/requirements.txt"
+echo "Installing Python runtime dependencies"
+pip install -r "$ROOT_DIR/requirements.txt"
 
-if [[ ! -f "$DB_PATH" ]]; then
-  echo "Database file does not exist: $DB_PATH" >&2
-  exit 1
+if [[ -f "$CACHE_FILE" ]]; then
+  cp "$CACHE_FILE" "$BACKUP_FILE"
+  echo "Backed up database to $BACKUP_FILE"
 fi
 
-# FIX: add PID to backup filename to avoid collisions
-BACKUP_FILE="${DB_PATH}.$(date +%Y%m%d%H%M%S)_$$.bak"
+export CRE_NO_CALCULATE_GAP_ANALYSIS=1
+export CRE_NO_GEN_EMBEDDINGS=1
 
-# Use sqlite3 backup (safe for live DB) and verify integrity
-"$VENV_DIR/bin/python" -c "
-import sqlite3, sys
-src, dst = sys.argv[1], sys.argv[2]
-try:
-    with sqlite3.connect(src) as src_conn, sqlite3.connect(dst) as dst_conn:
-        src_conn.backup(dst_conn)
-    cur = dst_conn.cursor()
-    cur.execute('PRAGMA integrity_check')
-    if cur.fetchone()[0] != 'ok':
-        print('Integrity check failed for backup', file=sys.stderr)
-        sys.exit(1)
-except Exception as e:
-    print(f'Backup failed: {e}', file=sys.stderr)
-    sys.exit(1)
-" "$DB_PATH" "$BACKUP_FILE"
+echo "Importing OWASP Cheat Sheet data into $CACHE_FILE"
+python "$ROOT_DIR/cre.py" --cheatsheets_in --cache_file "$CACHE_FILE"
 
-if [[ ! -f "$BACKUP_FILE" ]]; then
-  echo "Failed to create backup at $BACKUP_FILE" >&2
-  exit 1
-fi
-echo "Created verified backup at $BACKUP_FILE"
-
-CRE_NO_CALCULATE_GAP_ANALYSIS=1 \
-CRE_NO_GEN_EMBEDDINGS=1 \
-"$VENV_DIR/bin/python" "$ROOT_DIR/cre.py" --cheatsheets_in --cache_file "$DB_PATH"
-
-"$VENV_DIR/bin/python" - "$DB_PATH" <<'PY'
+# Normalise GitHub links to official HTML links
+python - "$CACHE_FILE" <<'PY'
 import os
 import sqlite3
 import sys