Invalid method argument

[toobiwankenobi]

Hi @ncborcherding ,

A very minor thing I noticed: it looks like runEscape does not check if the method argument is valid. Maybe this check could be added to the next version :)

GS <- list(Bcells = c("MS4A1", "CD79B", "CD79A", "IGH1", "IGH2"),
           Tcells = c("CD3E", "CD3D", "CD3G", "CD7","CD8A"))
pbmc_small <- SeuratObject::pbmc_small
pbmc_small <- runEscape(pbmc_small, method = "doesNotExist",
                        gene.sets = GS, 
                        min.size = NULL)
> Error in as.data.frame.default(a) : 
  cannot coerce class ‘c("gg", "ggplot")’ to a data.frame

Thank you and best wishes,
Tobi

[ncborcherding]

Thanks for the suggested - already implemented

escape/R/runEscape.R

Line 197 in ac252bd

method <- match.arg(method)