Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attempt to avoid creating and destorying dicts #91

Closed
wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 2, 2025

No description provided.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (4a99c14) to head (ecfa2d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   69.94%   70.28%   +0.34%     
==========================================
  Files           9        9              
  Lines         519      525       +6     
  Branches       43       44       +1     
==========================================
+ Hits          363      369       +6     
  Misses        139      139              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 2, 2025

CodSpeed Performance Report

Merging #91 will not alter performance

Comparing address_type_cache (ecfa2d0) with main (4a99c14)

Summary

✅ 1 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented Feb 2, 2025

its only ~0.5% faster.. within margin of error

@bdraco bdraco closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant