Skip to content

Commit eed8f79

Browse files
committed
Use the delegates registry-access instead of creating our own
1 parent 4ebceb8 commit eed8f79

File tree

5 files changed

+5
-25
lines changed

5 files changed

+5
-25
lines changed

implementations/fabric-1.20.5/src/main/java/de/bluecolored/bluemap/fabric/FabricCommandSource.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,13 @@
3131
import de.bluecolored.bluemap.common.serverinterface.ServerWorld;
3232
import de.bluecolored.bluemap.core.world.World;
3333
import me.lucko.fabric.api.permissions.v0.Permissions;
34-
import net.minecraft.registry.BuiltinRegistries;
35-
import net.minecraft.registry.RegistryWrapper;
3634
import net.minecraft.server.command.ServerCommandSource;
3735
import net.minecraft.util.math.Vec3d;
3836

3937
import java.util.Optional;
4038

4139
public class FabricCommandSource implements CommandSource {
4240

43-
private static final RegistryWrapper.WrapperLookup lookup = BuiltinRegistries.createWrapperLookup();
44-
4541
private final FabricMod mod;
4642
private final Plugin plugin;
4743
private final ServerCommandSource delegate;
@@ -56,7 +52,7 @@ public FabricCommandSource(FabricMod mod, Plugin plugin, ServerCommandSource del
5652
public void sendMessage(Text text) {
5753
delegate.sendFeedback(
5854
() -> net.minecraft.text.Text.Serialization
59-
.fromJson(text.toJSONString(), lookup),
55+
.fromJson(text.toJSONString(), delegate.getRegistryManager()),
6056
false
6157
);
6258
}

implementations/fabric/src/main/java/de/bluecolored/bluemap/fabric/FabricCommandSource.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,13 @@
3131
import de.bluecolored.bluemap.common.serverinterface.ServerWorld;
3232
import de.bluecolored.bluemap.core.world.World;
3333
import me.lucko.fabric.api.permissions.v0.Permissions;
34-
import net.minecraft.registry.BuiltinRegistries;
35-
import net.minecraft.registry.RegistryWrapper;
3634
import net.minecraft.server.command.ServerCommandSource;
3735
import net.minecraft.util.math.Vec3d;
3836

3937
import java.util.Optional;
4038

4139
public class FabricCommandSource implements CommandSource {
4240

43-
private static final RegistryWrapper.WrapperLookup lookup = BuiltinRegistries.createWrapperLookup();
44-
4541
private final FabricMod mod;
4642
private final Plugin plugin;
4743
private final ServerCommandSource delegate;
@@ -56,7 +52,7 @@ public FabricCommandSource(FabricMod mod, Plugin plugin, ServerCommandSource del
5652
public void sendMessage(Text text) {
5753
delegate.sendFeedback(
5854
() -> net.minecraft.text.Text.Serialization
59-
.fromJson(text.toJSONString(), lookup),
55+
.fromJson(text.toJSONString(), delegate.getRegistryManager()),
6056
false
6157
);
6258
}

implementations/forge-1.20.6/src/main/java/de/bluecolored/bluemap/forge/ForgeCommandSource.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,12 @@
3131
import de.bluecolored.bluemap.common.serverinterface.ServerWorld;
3232
import de.bluecolored.bluemap.core.world.World;
3333
import net.minecraft.commands.CommandSourceStack;
34-
import net.minecraft.core.HolderLookup;
35-
import net.minecraft.data.registries.VanillaRegistries;
3634
import net.minecraft.network.chat.Component;
3735

3836
import java.util.Optional;
3937

4038
public class ForgeCommandSource implements CommandSource {
4139

42-
private static final HolderLookup.Provider lookup = VanillaRegistries.createLookup();
43-
4440
private final ForgeMod mod;
4541
private final Plugin plugin;
4642
private final CommandSourceStack delegate;
@@ -53,7 +49,7 @@ public ForgeCommandSource(ForgeMod mod, Plugin plugin, CommandSourceStack delega
5349

5450
@Override
5551
public void sendMessage(Text text) {
56-
var component = Component.Serializer.fromJsonLenient(text.toJSONString(), lookup);
52+
var component = Component.Serializer.fromJsonLenient(text.toJSONString(), delegate.registryAccess());
5753
if (component != null)
5854
delegate.sendSuccess(() -> component, false);
5955
}

implementations/forge/src/main/java/de/bluecolored/bluemap/forge/ForgeCommandSource.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,12 @@
3131
import de.bluecolored.bluemap.common.serverinterface.ServerWorld;
3232
import de.bluecolored.bluemap.core.world.World;
3333
import net.minecraft.commands.CommandSourceStack;
34-
import net.minecraft.core.HolderLookup;
35-
import net.minecraft.data.registries.VanillaRegistries;
3634
import net.minecraft.network.chat.Component;
3735

3836
import java.util.Optional;
3937

4038
public class ForgeCommandSource implements CommandSource {
4139

42-
private static final HolderLookup.Provider lookup = VanillaRegistries.createLookup();
43-
4440
private final ForgeMod mod;
4541
private final Plugin plugin;
4642
private final CommandSourceStack delegate;
@@ -53,7 +49,7 @@ public ForgeCommandSource(ForgeMod mod, Plugin plugin, CommandSourceStack delega
5349

5450
@Override
5551
public void sendMessage(Text text) {
56-
var component = Component.Serializer.fromJsonLenient(text.toJSONString(), lookup);
52+
var component = Component.Serializer.fromJsonLenient(text.toJSONString(), delegate.registryAccess());
5753
if (component != null)
5854
delegate.sendSuccess(() -> component, false);
5955
}

implementations/neoforge/src/main/java/de/bluecolored/bluemap/forge/ForgeCommandSource.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,12 @@
3131
import de.bluecolored.bluemap.common.serverinterface.ServerWorld;
3232
import de.bluecolored.bluemap.core.world.World;
3333
import net.minecraft.commands.CommandSourceStack;
34-
import net.minecraft.core.HolderLookup;
35-
import net.minecraft.data.registries.VanillaRegistries;
3634
import net.minecraft.network.chat.Component;
3735

3836
import java.util.Optional;
3937

4038
public class ForgeCommandSource implements CommandSource {
4139

42-
private static final HolderLookup.Provider lookup = VanillaRegistries.createLookup();
43-
4440
private final ForgeMod mod;
4541
private final Plugin plugin;
4642
private final CommandSourceStack delegate;
@@ -53,7 +49,7 @@ public ForgeCommandSource(ForgeMod mod, Plugin plugin, CommandSourceStack delega
5349

5450
@Override
5551
public void sendMessage(Text text) {
56-
var component = Component.Serializer.fromJsonLenient(text.toJSONString(), lookup);
52+
var component = Component.Serializer.fromJsonLenient(text.toJSONString(), delegate.registryAccess());
5753
if (component != null)
5854
delegate.sendSuccess(() -> component, false);
5955
}

0 commit comments

Comments
 (0)