Confirmed balances have to be positive

shesek · shesek · commit d1fd717d5e5d · 2021-02-15T23:51:48.000+02:00
h/t @sgeisler bitcoindevkit/rust-electrum-client#45 (comment)
diff --git a/src/electrum/server.rs b/src/electrum/server.rs
@@ -286,7 +286,7 @@ impl Connection {
         let (chain_stats, mempool_stats) = self.query.stats(&script_hash[..]);
 
         Ok(json!({
-            "confirmed": chain_stats.funded_txo_sum as i64 - chain_stats.spent_txo_sum as i64,
+            "confirmed": chain_stats.funded_txo_sum - chain_stats.spent_txo_sum,
             "unconfirmed": mempool_stats.funded_txo_sum as i64 - mempool_stats.spent_txo_sum as i64,
         }))
     }

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ impl Connection {`
`286`	`286`	`let (chain_stats, mempool_stats) = self.query.stats(&script_hash[..]);`
`287`	`287`
`288`	`288`	`Ok(json!({`
`289`		`- "confirmed": chain_stats.funded_txo_sum as i64 - chain_stats.spent_txo_sum as i64,`
	`289`	`+ "confirmed": chain_stats.funded_txo_sum - chain_stats.spent_txo_sum,`
`290`	`290`	`"unconfirmed": mempool_stats.funded_txo_sum as i64 - mempool_stats.spent_txo_sum as i64,`
`291`	`291`	`}))`
`292`	`292`	`}`