Skip to content

Commit 4477302

Browse files
committed
fix isuues
1 parent acca0dc commit 4477302

File tree

2 files changed

+29
-14
lines changed

2 files changed

+29
-14
lines changed

src/routes/character.route.js

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,23 @@ const path = require("path");
55
const fs = require("fs");
66
const { uploadCharacter, getAllCharacters } = require("../controllers/characterController");
77

8-
const uploadDir = path.join(__dirname, "../../uploads");
9-
if (!fs.existsSync(uploadDir)) {
8+
let uploadDir;
9+
10+
try {
11+
uploadDir = path.join(process.cwd(), "uploads");
12+
if (!fs.existsSync(uploadDir)) {
13+
fs.mkdirSync(uploadDir, { recursive: true });
14+
}
15+
} catch (err) {
16+
console.error("⚠️ Failed to create upload directory, using /tmp instead:", err);
17+
uploadDir = "/tmp/uploads";
1018
fs.mkdirSync(uploadDir, { recursive: true });
1119
}
1220

1321
const storage = multer.diskStorage({
14-
destination: (req, file, cb) => {
15-
cb(null, uploadDir);
16-
},
22+
destination: (req, file, cb) => cb(null, uploadDir),
1723
filename: (req, file, cb) => {
18-
cb(null, file.fieldname + "-" + Date.now() + path.extname(file.originalname));
24+
cb(null, `${file.fieldname}-${Date.now()}${path.extname(file.originalname)}`);
1925
},
2026
});
2127

src/routes/sketch.route.js

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,28 @@ const path = require("path");
55
const fs = require("fs");
66
const { uploadSketch, getAllSketches } = require("../controllers/sketchController");
77

8-
const uploadDir = path.join(__dirname, "../../uploads");
8+
let uploadDir;
99

10-
if (!fs.existsSync(uploadDir)) {
10+
try {
11+
// Prefer creating uploads directory in the current working directory
12+
uploadDir = path.join(process.cwd(), "uploads");
13+
if (!fs.existsSync(uploadDir)) {
1114
fs.mkdirSync(uploadDir, { recursive: true });
15+
}
16+
} catch (err) {
17+
console.error("⚠️ Failed to create upload directory in project root. Falling back to /tmp:", err);
18+
uploadDir = "/tmp/uploads";
19+
fs.mkdirSync(uploadDir, { recursive: true });
1220
}
1321

22+
console.log("✅ Sketch uploads directory:", uploadDir);
23+
1424
const storage = multer.diskStorage({
15-
destination: (req, file, cb) => {
16-
cb(null, uploadDir);
17-
},
18-
filename: (req, file, cb) => {
19-
cb(null, file.fieldname + "-" + Date.now() + path.extname(file.originalname));
20-
},
25+
destination: (req, file, cb) => cb(null, uploadDir),
26+
filename: (req, file, cb) => {
27+
const uniqueName = `${file.fieldname}-${Date.now()}${path.extname(file.originalname)}`;
28+
cb(null, uniqueName);
29+
},
2130
});
2231

2332
const upload = multer({ storage });

0 commit comments

Comments
 (0)