Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in new wkv6state_cuda #241

Open
SmerkyG opened this issue Apr 30, 2024 · 0 comments
Open

bug in new wkv6state_cuda #241

SmerkyG opened this issue Apr 30, 2024 · 0 comments

Comments

@SmerkyG
Copy link

SmerkyG commented Apr 30, 2024

_s += h*_N_*_N_ + i*_N_;

This line is missing the batch offset and should read:
_s += b*H*_N_*_N_ + h*_N_*_N_ + i*_N_;

Probably why this code didn't work for BPTT when we tried it a while back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant