Skip to content

Commit 3668d9e

Browse files
committed
Don't require covers annotation in tests
1 parent e8f7bb4 commit 3668d9e

File tree

8 files changed

+16
-9
lines changed

8 files changed

+16
-9
lines changed

.php-cs-fixer.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<?php
22

33
use Ergebnis\PhpCsFixer\Config;
4+
use PhpCsFixer\RuleSet\RuleSet;
45

56
$header = <<<EOF
67
Copyright (c) 2021 Kai Sassnowski
@@ -11,7 +12,9 @@
1112
@see https://github.com/roach-php/roach
1213
EOF;
1314

14-
$config = Config\Factory::fromRuleSet(new Config\RuleSet\Php80($header));
15+
$config = Config\Factory::fromRuleSet(new Config\RuleSet\Php80($header), [
16+
'php_unit_test_class_requires_covers' => false,
17+
]);
1518

1619
$config->getFinder()->in(__DIR__);
1720
$config->setCacheFile(__DIR__ . '/.build/php-cs-fixer/.php-cs-fixer.cache');

phpunit.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
bootstrap="vendor/autoload.php"
55
cacheResultFile=".phpunit.cache/test-results"
66
executionOrder="depends,defects"
7-
forceCoversAnnotation="true"
7+
forceCoversAnnotation="false"
88
beStrictAboutCoversAnnotation="true"
99
beStrictAboutOutputDuringTests="true"
1010
beStrictAboutTodoAnnotatedTests="true"

tests/EngineTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
use Sassnowski\Roach\Spider\ParseResult;
2323

2424
/**
25-
* @covers \Sassnowski\Roach\Engine
26-
*
2725
* @internal
2826
* @group integration
2927
*/

tests/Http/Middleware/MiddlewareStackTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
use Sassnowski\Roach\Tests\InteractsWithRequests;
2727

2828
/**
29-
* @covers \Sassnowski\Roach\Http\Middleware\MiddlewareStack
3029
* @group middleware
3130
*
3231
* @internal

tests/Http/Middleware/RequestDeduplicationMiddlewareTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
use Sassnowski\Roach\Tests\InteractsWithRequests;
2424

2525
/**
26-
* @covers \Sassnowski\Roach\Http\Middleware\RequestDeduplicationMiddleware
2726
* @group middleware
2827
*
2928
* @internal
@@ -76,7 +75,7 @@ public function testLogDroppedRequests(): void
7675
$middleware->handle($request, $handler);
7776

7877
self::assertTrue(
79-
$logger->messageWasLogged('info', 'Dropping duplicate request', ['uri' => '::url::'])
78+
$logger->messageWasLogged('info', 'Dropping duplicate request', ['uri' => '::url::']),
8079
);
8180
}
8281

tests/Logging/FakeLoggerTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
use Sassnowski\Roach\Logging\FakeLogger;
1919

2020
/**
21-
* @covers \Sassnowski\Roach\Logging\FakeLogger
2221
* @group testing
2322
*
2423
* @internal

tests/Queue/ArrayQueueTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
use Sassnowski\Roach\Tests\InteractsWithRequests;
1919

2020
/**
21-
* @covers \Sassnowski\Roach\Queue\ArrayRequestQueue
2221
* @group queue
2322
*
2423
* @internal

tests/Spider/ParseResultTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?php
2+
3+
4+
namespace Sassnowski\Roach\Tests\Spider;
5+
6+
7+
class ParseResultTest
8+
{
9+
10+
}

0 commit comments

Comments
 (0)