Removed unnecessary returns

Author: DanielThedie

R/Data_import.r

@@ -30,7 +30,7 @@ make_graph_from_df <- function(data, delimiter = ";", column_name = "Author", di
 
   graph <- igraph::graph_from_data_frame(edges, directed = directed)
   print(paste0("Constructed network with ", graph |> igraph::vcount(), " authors"))
-  return(graph)
+  graph
 }
 
 #' @export
@@ -93,5 +93,5 @@ read_metadata <- function(metadata) {
   metadata$Data_source_url <- NULL
   names(metadata) <- gsub("_", " ", names(metadata))
 
-  return(metadata)
+  metadata
 }

R/Date_manager.r

@@ -16,7 +16,7 @@ get_years_from_to <- function(data, config) {
     years_from <- year_from
     years_to <- year_to
   }
-  return(list(years_from = years_from, years_to = years_to))
+  list(years_from = years_from, years_to = years_to)
 }
 
 #' @export

R/Descriptive_stats.r

@@ -11,13 +11,13 @@ get_author_stats <- function(data, author_column_name = "Author", delimiter = ";
   all_authors <- unique(unlist(strsplit(paste(author_column, collapse = delimiter), delimiter)))
   unique_author_count <- length(all_authors)
 
-  return(list(
+  list(
     sum = unique_author_count,
     average = avg_authors,
     median = median_authors,
     min = min_authors,
     max = max_authors
-  ))
+  )
 }
 
 #' @export

R/Filtering.r

@@ -36,7 +36,7 @@ filter_papers_by_authors <- function(data, column_name = "Author", delimiter = "
     dplyr::select(-item_list, -Num_items)
   print(paste0(nrow(filtered_data), " papers were included in the network analysis."))
 
-  return(list(filtered_data, too_many, too_few))
+  list(filtered_data, too_many, too_few)
 }
 
 #' @export
@@ -70,5 +70,5 @@ filter_infrequent_authors <- function(data, column_name = "Author", delimiter =
     print(paste0("Removed ", removed_authors, " authors that appeared less than ", min_occurrences, " times."))
   }
 
-  return(list(filtered_data, removed_authors))
+  list(filtered_data, removed_authors)
 }

R/Interactions.plots.R

@@ -37,7 +37,7 @@ plot_graph.Interactions <- function(interactions, centrality = "degree", output_
   }
 
   dev.off()
-  return(output_file)
+  output_file
 }
 
 plot_graph <- function(interactions, centrality, output_file) {
@@ -92,7 +92,7 @@ plot_cutpoints.Interactions <- function(interactions, centrality = "degree", out
 
     dev.off()
   }
-  return(output_file)
+  output_file
 }
 
 plot_cutpoints <- function(interactions, centrality, output_file) {
@@ -136,7 +136,7 @@ plot_top_authors.Interactions <- function(interactions, n = 10, output_file = "o
   )
 
   dev.off()
-  return(output_file)
+  output_file
 }
 
 plot_top_authors <- function(interactions, n, output_file) {
@@ -182,4 +182,4 @@ get_palette <- function(alpha = 1) {
     "#FF1493", "#0000FF", "#000000", "#4682B4", "#00CED1",
     "#00FF00", "#808000", "#FFFF00", "#FF8C00", "#A52A2A"
   ), alpha.f = alpha)
-}
+}

R/Interactions_class.r

@@ -63,7 +63,7 @@ Interactions <- function(data,
 
   class(interactions) <- "Interactions"
 
-  return(interactions)
+  interactions
 }
 
 #' @export
@@ -79,7 +79,7 @@ generate_network_metrics.Interactions <- function(interactions) {
   interactions$top_authors_degree <- get_most_central_authors(interactions, centrality = "degree", n = 15)
   interactions$top_authors_betweenness <- get_most_central_authors(interactions, centrality = "betweenness", n = 15)
   interactions$top_authors_harmonic <- get_most_central_authors(interactions, centrality = "harmonic", n = 15)
-  return(interactions)
+  interactions
 }
 
 generate_network_metrics <- function(interactions) {
@@ -94,7 +94,7 @@ generate_figures.Interactions <- function(interactions, paths, date_range) {
   fig4 <- plot_graph(interactions, centrality = "betweenness", output_file = paste0(paths$figures, "/graph_betweenness_", date_range, ".png"))
   fig5 <- plot_graph(interactions, centrality = "harmonic", output_file = paste0(paths$figures, "/graph_harmonic_", date_range, ".png"))
   fig6 <- plot_graph(interactions, centrality = "none", output_file = paste0(paths$figures, "/graph_no_centrality_", date_range, ".png"))
-  return(list(fig1 = fig1, fig2 = fig2, fig3 = fig3, fig4 = fig4, fig5 = fig5, fig6 = fig6))
+  list(fig1 = fig1, fig2 = fig2, fig3 = fig3, fig4 = fig4, fig5 = fig5, fig6 = fig6)
 }
 
 generate_figures <- function(interactions, paths, date_range) {
@@ -106,7 +106,7 @@ get_cohesion.Interactions <- function(interactions) {
   dyadcount <- network::network.dyadcount(interactions$network)
   edgecount <- network::network.edgecount(interactions$network)
   size <- network::network.size(interactions$network)
-  return(list(dyadcount = dyadcount, edgecount = edgecount, size = size))
+  list(dyadcount = dyadcount, edgecount = edgecount, size = size)
 }
 
 get_cohesion <- function(interactions) {
@@ -136,7 +136,7 @@ get_centrality.Interactions <- function(interactions) {
   degree <- igraph::degree(interactions$graph)
   harmonic <- igraph::harmonic_centrality(interactions$graph)
   betweenness <- igraph::betweenness(interactions$graph)
-  return(list(degree = degree, harmonic = harmonic, betweenness = betweenness))
+  list(degree = degree, harmonic = harmonic, betweenness = betweenness)
 }
 
 get_centrality <- function(interactions) {
@@ -148,7 +148,7 @@ get_diameter.Interactions <- function(interactions) {
   diameter <- igraph::diameter(interactions$graph, directed = interactions$directed, weights = NULL)
   shortest_paths <- igraph::distances(interactions$graph)
   average_shortest_path <- mean(shortest_paths[shortest_paths != Inf])
-  return(list(diameter = diameter, average_shortest_path = average_shortest_path))
+  list(diameter = diameter, average_shortest_path = average_shortest_path)
 }
 
 get_diameter <- function(interactions) {
@@ -160,9 +160,7 @@ get_reachability.Interactions <- function(interactions) {
   reachability_matrix <- sna::reachability(interactions$network)
   num_nodes <- nrow(reachability_matrix)
   total_pairs <- num_nodes * (num_nodes - 1)
-  num_unreachable_pairs <- sum(reachability_matrix == 0) - num_nodes
-  unreachable_fraction <- num_unreachable_pairs / total_pairs
-  return(unreachable_fraction)
+  (sum(reachability_matrix == 0) - num_nodes) / total_pairs
 }
 
 get_reachability <- function(interactions) {

R/Paths_resolver.r

@@ -15,7 +15,7 @@ Paths <- function(config) {
 
   class(paths) <- "Paths"
 
-  return(paths)
+  paths
 }
 
 create_output_paths <- function(config) {
@@ -35,7 +35,7 @@ create_output_paths <- function(config) {
   if (!dir.exists(data_path)) {
     dir.create(data_path, recursive = TRUE)
   }
-  return(config)
+  config
 }
 
 get_input_path <- function(config) {

R/Text_utils.r

@@ -29,9 +29,9 @@ format_names <- function(name_list) {
     } else {
       formatted_name <- name
     }
-    return(formatted_name)
+    formatted_name
   })
-  return(name_list)
+  name_list
 }
 
 #' @export
@@ -67,5 +67,5 @@ escape_latex <- function(text) {
   text <- gsub("\\}", "\\\\}", text)
   text <- gsub("\\^", "\\\\textasciicircum{}", text)
   text <- gsub("~", "\\\\textasciitilde{}", text)
-  return(text)
+  text
 }