Wait for LiveView readiness in deployed browser checks - #1661
Merged
Conversation
This was referenced Sep 6, 2026
jhgaylor
marked this pull request as ready for review
September 6, 2026 11:28
managoat-switchyard
Bot
force-pushed
the
codex/conformance-qualification
branch
from
September 7, 2026 10:10
84f5c4d to
0e8e253
Compare
Contributor
Review Loop · Human review neededRevision: Verification command cancelled; no exit evidence 3 optional finding(s) accepted · 1 finding(s) resolved or dismissed. Full findings remain in the run details. Usage: 3765031 reported tokens (some task usage unavailable). Approval does not merge the PR. |
managoat-review-loop
Bot
added
the
needs-human-review
![managoat-review-loop[bot]](https://avatars.githubusercontent.com/u/321987611?s=60&v=4){kind=small}
jhgaylor
removed
the
needs-human-review
managoat-review-loop
Bot
added
the
needs-human-review
A multi-provider deployment, or a sole provider whose selector is visible, selects the pinned provider explicitly, so the saved agent must store it. The `?? default` fallback let a null stored provider pass whenever the instance default happened to equal the pin. Only a hidden sole-provider selector may rely on the effective instance default. The selection and persistence steps are lifted into selectBrowserProvider and verifyBrowserProvider so browser-console.test.mjs can drive them against a fake selector; the two fix-targeting tests fail against the old fallback. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JRqdEnAYoRN73f7qjpizjL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployed browser driver could submit a visible form before LiveView connected. A production run timed out waiting for empty-credential validation; a diagnostic observed
connected=0after navigation and passed after waiting for the connection.Wait for
[data-phx-main].phx-connectedbefore interacting with console LiveView forms. Use the public catalog to determine whether the provider selector is required, so a zero DOM count during an update does not imply a single-provider deployment. Also independently verify the saved agent's provider. Assertions and time limits remain intact.Validation: all 185 harness tests passed after each change. The corrected production driver passed sign-in and empty credential validation. It then exposed the fresh-account agent-form problem recorded in #1660; the full console/key/app journey has no passing verdict yet. Original failures and the allowlisted diagnostic are retained under
/private/tmp/fountain-conformance-live-20260906/. Both owned test accounts and keys were removed, and the original fixture settings were restored. The same released image also passed isolated fresh-Compose registration, first-admin sign-in/sign-out and cleanup.Part of #1618 and tracker #1606. This change fixes test-driver readiness; it does not resolve the nested credential form in #1660 or complete #1618.