Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch false async suffix #31

Open
Jesse-Hufstetler opened this issue Apr 9, 2018 · 1 comment
Open

Catch false async suffix #31

Jesse-Hufstetler opened this issue Apr 9, 2018 · 1 comment

Comments

@Jesse-Hufstetler
Copy link

I'd like it if the extension would tell me when I end a non-async method name with Async.

This comes up sometimes when I convert something to async and then convert it back.

@mkeus
Copy link

mkeus commented Jan 9, 2020

I think it is better to not use the suffix at all. To my opinion, the suffix was introduced in the beginning of async, when there was a sync and an async version of the same method, so there should be a difference in naming for the compiler, otherwise, it would raise an error. But a function name should tell what it does, not how he does it.

We are now at the time that most of our code uses async methods and there are no sync versions of the same method, so why should you decorate all the methods with async? Only when you have both versions the suffix makes sense,

It would be nice if the option to not suggest the async suffix becomes global and not only for test methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants