From 53980f755a2572e762e4cb29f0ba4a5927ac7fd2 Mon Sep 17 00:00:00 2001 From: BenWinchester Date: Thu, 25 Apr 2024 11:21:00 +0100 Subject: [PATCH] :bug: Experiment with changed reflectivity calculation --- src/pvt_model/pvt_system/pvt_collector/__utils__.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pvt_model/pvt_system/pvt_collector/__utils__.py b/src/pvt_model/pvt_system/pvt_collector/__utils__.py index c1d428d..94f063e 100644 --- a/src/pvt_model/pvt_system/pvt_collector/__utils__.py +++ b/src/pvt_model/pvt_system/pvt_collector/__utils__.py @@ -161,6 +161,10 @@ def reflectivity(self) -> float: """ + # FIXME: I'm not convinced that this calculation is correct... + + return 1 - self.absorptivity - self.transmissivity + return sqrt(1 - self.absorptivity**2 - self.transmissivity**2) @property