Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Library Media Resize Glitch on Windows Machine #72

Open
Grey41 opened this issue Mar 13, 2022 · 1 comment
Open

[Bug] Library Media Resize Glitch on Windows Machine #72

Grey41 opened this issue Mar 13, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Grey41
Copy link

Grey41 commented Mar 13, 2022

Packages & versions

Media v0.11.0

Describe the bug

I attempted to compile and test Library Media for Windows.
When I tried to resize the media display window, it shot off the screen and became very small.
Unfortunately, this would make it unusable for a Windows machine.

Reproduction steps

  • Download and build Library Media on a Windows machine
  • Try to resize the media display window

Expected behavior

I expected the window to resize smoothly, just like any other window.

@Grey41 Grey41 added the bug Something isn't working label Mar 13, 2022
@Grey41 Grey41 changed the title [Bug] Library Media Resize Glitch on Windows [Bug] Library Media Resize Glitch on Windows Machine Mar 13, 2022
@BenShelton
Copy link
Owner

BenShelton commented Mar 13, 2022

We use a library to keep a 16:9 aspect ratio on the display window: https://github.com/antonfisher/electron-aspect-ratio-browser-window

Evidently this doesn't seem to work on Windows. Perhaps the best thing to do for now is to not keep the aspect ratio on Windows and instead only set this up on darwin.

There also seems to have been improvements in this area such as in electron/electron#26941 which might mean we implement our own version of aspect ratio using these updated methods. The code from the library we use is actually very minimal.

As I don't have a Windows machine though this would be difficult for me to test so any help would be appreciated.

@BenShelton BenShelton added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants