Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated call to EventDispatcherInterface::dispatch() #58

Open
Yoluk opened this issue Mar 2, 2020 · 1 comment
Open

Deprecated call to EventDispatcherInterface::dispatch() #58

Yoluk opened this issue Mar 2, 2020 · 1 comment

Comments

@Yoluk
Copy link

Yoluk commented Mar 2, 2020

Hello,
I'm currently maintaining a Symfony 4.3 project using this bundle, and I get a lot of deprecated logs saying this :

 Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as the first argument is deprecated since Symfony 4.3, pass it as the second argument and provide the event object as the first argument instead

After a bit of research, it appears that in the following commit, the two parameters have been switched : symfony/event-dispatcher@1a30b07

Would it be possible to update this line in the bundle, to switch the parameters ?
https://github.com/M6Web/AmqpBundle/blob/master/src/AmqpBundle/Amqp/AbstractAmqp.php#L41
I can provide a pull request, if needed.
Best regards

@Oliboy50
Copy link
Member

Oliboy50 commented Mar 2, 2020

hello 👋
you're right, our bundle in not compatible with Symfony 5.0 ATM

as stated in the description of this PR:

it's not compatible with SF 5 yet (DataCollector does not work and base SF event does not exist)

...

but it's not possible to support symfony 3, 4 and 5 at the same time

...

the next step could be to remove support for sf 3 and add support for sf 5

=> we would appreciate if we could simply bump a single major release to drop support for sf 3 and gain support for sf 5

so, yes, if you think you could handle such a PR, it would be a huge help 🙇

I can tell you that you'll have to edit the .travis.yml file to remove:

        - php: 7.2
          env: SYMFONY_REQUIRE="3.4.*"

and add:

        - php: 7.4
          env: SYMFONY_REQUIRE="5.0.*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants