Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When uploading multiple images to Works, removing an image does not work. #416

Closed
skullbunnygalaxy opened this issue Sep 28, 2022 · 2 comments · Fixed by #802
Closed

When uploading multiple images to Works, removing an image does not work. #416

skullbunnygalaxy opened this issue Sep 28, 2022 · 2 comments · Fixed by #802
Labels
bug Something isn't working

Comments

@skullbunnygalaxy
Copy link
Contributor

skullbunnygalaxy commented Sep 28, 2022

  1. When on your studio's portfolio page, select an image for upload.
  2. Then try to remove it.
  3. Select a different image for upload.

When you select another image for upload, it will re-add the removed image. Even if you remove the image again, it will upload the image anyways when you hit save.

@skullbunnygalaxy skullbunnygalaxy added the bug Something isn't working label Sep 28, 2022
@zkat zkat moved this to Backlog in Banchan Art MVP Sep 28, 2022
@zkat zkat removed this from Banchan Art MVP Jul 6, 2023
@zkat zkat moved this to Backlog in Banchan Art Post-MVP Roadmap Jul 6, 2023
@zkat zkat moved this to 📋 Backlog in Banchan Project Roadmap Aug 19, 2023
@zkat
Copy link
Contributor

zkat commented Aug 19, 2023

Just more portfolio suckage. I think this is related to #633

@skullbunnygalaxy
Copy link
Contributor Author

#633 closed due to new works feature, but this issue appears to be happening with the new works feature (#788). I was going to make a new issue but noticed this one hadn't been closed with 633. It seems like these are all the same issue.

Replication steps:

  1. Create a new work.
  2. Upload an image.
  3. Hit X on image to remove it.
  4. Upload new image.
  5. Previous image that was removed will re-appear. This happens every time you add an additional image to the work.

Additionally, even if you remove the image before saving, the removed image still apears in the new work, which means the x button isn't really working on new uploads.

The image can be removed successfully when editing an already created work.

@skullbunnygalaxy skullbunnygalaxy changed the title When uploading multiple images to portfolio, removing an image does not work. When uploading multiple images to Works, removing an image does not work. Apr 6, 2024
@zkat zkat linked a pull request Apr 20, 2024 that will close this issue
@zkat zkat closed this as completed in #802 Apr 20, 2024
zkat added a commit that referenced this issue Apr 20, 2024
Fixes: #416

They needed to be canceled, not just removed from the list.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Banchan Project Roadmap Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants