Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the flag list #55

Open
slifty opened this issue Mar 9, 2019 · 0 comments
Open

Implement the flag list #55

slifty opened this issue Mar 9, 2019 · 0 comments

Comments

@slifty
Copy link
Member

slifty commented Mar 9, 2019 •
edited
Loading

The flag list pane shows the flags currently rendered on screen. This issue captures:

  • Rendering the list of flags that are currently visible in the editor pane
  • Allowing the user to "select" a flag by clicking on it
  • Showing the total number of flagged phrases

This issue does not include the flag detail view; so when a flag is selected that state should be reflected in the app, but it doesn't need to translate to a rendering of the detail view yet.

This also does not have to render the flag toggle yet (which is already captured in issue #47)

image
slifty added a commit that referenced this issue Mar 19, 2019
@slifty
Render the card list
393664a 
When there are flags to show, show them.

This renders all flags, it doesn't take into account which flags
actually appear on the editor.  The flags are also not clickable from
the list view.

Issue #55
slifty added a commit that referenced this issue Mar 19, 2019
@slifty
Add real data
54d1dc8 
We aren't going to check the data in (since it isn't ours to share yet)
but this loads a local dataset.  If you wanted to add your own phrases,
there is an example data set at example.data.js

Issue #55
slifty added a commit that referenced this issue Mar 19, 2019
@slifty
Add real data
63391ba 
We aren't going to check the data in (since it isn't ours to share yet)
but this loads a local dataset.  If you wanted to add your own phrases,
there is an example data set at example.data.js

Issue #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slifty