From 8dc3977f0284af1d2254a5f5e8d049037df3e3e5 Mon Sep 17 00:00:00 2001 From: Tzu-Mao Li Date: Mon, 8 Jan 2024 16:01:37 -0500 Subject: [PATCH 1/3] Update c-cpp.yml --- .github/workflows/c-cpp.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/c-cpp.yml b/.github/workflows/c-cpp.yml index 3ad65d8..d7de1c6 100644 --- a/.github/workflows/c-cpp.yml +++ b/.github/workflows/c-cpp.yml @@ -28,7 +28,5 @@ jobs: run: mkdir build; cd build; cmake .. - name: make run: cd build; cmake --build . -j -v - - name: macos-test - run: cd build; ./test_filter - #- name: test - # run: cd build; ctest + - name: test + run: cd build; ctest From 706aaeb8a4b749261115cb59718aff2e106525dc Mon Sep 17 00:00:00 2001 From: Jason Foat Date: Thu, 11 Jan 2024 22:15:27 -0800 Subject: [PATCH 2/3] Fixed unused variable warning. --- src/tests/matrix.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/tests/matrix.cpp b/src/tests/matrix.cpp index b455c16..e25d3dc 100644 --- a/src/tests/matrix.cpp +++ b/src/tests/matrix.cpp @@ -10,7 +10,6 @@ int main(int argc, char *argv[]) { ); Matrix4x4 m_inv = inverse(m); Matrix4x4 m_inv_m = m_inv * m; - int count = 1; for (int i = 0; i < 4; i++) { for (int j = 0; j < 4; j++) { Real target = i == j ? Real(1) : Real(0); @@ -18,7 +17,6 @@ int main(int argc, char *argv[]) { printf("FAIL\n"); return 1; } - count++; } } From 282c3b364f32b7bd54e71503aadf196ff26caab2 Mon Sep 17 00:00:00 2001 From: Jason Foat Date: Thu, 11 Jan 2024 22:25:03 -0800 Subject: [PATCH 3/3] Added missing info to README.md --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 50805fb..db805c8 100644 --- a/README.md +++ b/README.md @@ -8,10 +8,11 @@ If you are on Unix systems, try mkdir build cd build cmake .. +cmake --build . ``` It requires compilers that support C++17 (gcc version >= 8, clang version >= 7, Apple Clang version >= 11.0, MSVC version >= 19.14). -Apple M1 users: you might need to build Embree from scratch since the prebuilt MacOS binary provided is built for x86 machines. +Apple M1 users: you might need to build Embree from scratch since the prebuilt MacOS binary provided is built for x86 machines. (But try build command above first.) # Run Try