Skip to content

Commit c0bb89c

Browse files
committed
frontend: add lint rule for ":deep usage as a combinator has been deprecated"
Issue: ecamp#5121
1 parent 7c6ce39 commit c0bb89c

File tree

8 files changed

+212
-17
lines changed

8 files changed

+212
-17
lines changed

frontend/package-lock.json

+192
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/package.json

+2
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
"eslint-plugin-prettier": "5.1.3",
104104
"eslint-plugin-promise": "6.1.1",
105105
"eslint-plugin-vue": "9.25.0",
106+
"eslint-plugin-vue-scoped-css": "2.8.0",
106107
"flush-promises": "1.0.2",
107108
"jest-serializer-vue-tjw": "3.20.0",
108109
"jsdom": "24.0.0",
@@ -125,6 +126,7 @@
125126
},
126127
"extends": [
127128
"plugin:vue/recommended",
129+
"plugin:vue-scoped-css/vue3-recommended",
128130
"eslint:recommended",
129131
"plugin:prettier/recommended",
130132
"@vue/eslint-config-prettier"

frontend/src/components/activity/DraggableContentNodes.vue

+7-6
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export default {
171171
min-height: 10rem;
172172
}
173173
174-
.draggable-area ::v-deep .content-node {
174+
.draggable-area ::v-deep(.content-node) {
175175
margin: 0 !important;
176176
flex-grow: 1;
177177
transition: all 0.4s 25ms ease;
@@ -194,10 +194,11 @@ export default {
194194
195195
@supports selector(:has(+ *)) {
196196
.draggable-area--layout-mode
197-
::v-deep
198-
.content-node:hover:is(
199-
:not(:has(.content-node:hover)):not(:has(.ec-button-contentnode-add:hover)):not(
200-
:has(.resize-btn:hover)
197+
::v-deep(
198+
.content-node:hover:is(
199+
:not(:has(.content-node:hover)):not(:has(.ec-button-contentnode-add:hover)):not(
200+
:has(.resize-btn:hover)
201+
)
201202
)
202203
) {
203204
box-shadow:
@@ -207,7 +208,7 @@ export default {
207208
}
208209
}
209210
210-
.draggable-area--row ::v-deep .content-node {
211+
.draggable-area--row ::v-deep(.content-node) {
211212
flex: 1 0 320px !important;
212213
}
213214

frontend/src/components/collaborator/CollaboratorForm.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export default {
120120
</script>
121121

122122
<style scoped>
123-
.ec-status-field::v-deep .v-input__append-inner {
123+
.ec-status-field::v-deep(.v-input__append-inner) {
124124
margin-top: 0;
125125
align-self: center;
126126
margin-right: -4px;

frontend/src/components/program/picasso/PicassoEntry.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ export default {
494494
}
495495
}
496496
497-
:deep .e-avatarrow {
497+
:deep(.e-avatarrow) {
498498
position: absolute;
499499
bottom: 2px;
500500
right: 2px;

frontend/src/components/prompt/PopoverPrompt.vue

+6-6
Original file line numberDiff line numberDiff line change
@@ -151,25 +151,25 @@ export default {
151151
flex-grow: 1;
152152
}
153153
154-
.ec-popover-prompt ::v-deep .ec-activator .v-btn {
154+
.ec-popover-prompt ::v-deep(.ec-activator .v-btn) {
155155
position: absolute;
156156
background-color: white !important;
157157
color: #424242 !important;
158158
}
159159
160-
.ec-popover-prompt ::v-deep .ec-activator .v-btn:hover::before {
160+
.ec-popover-prompt ::v-deep(.ec-activator .v-btn:hover::before) {
161161
opacity: 0;
162162
}
163163
164-
.ec-popover-prompt--align-left ::v-deep .ec-activator .v-btn {
164+
.ec-popover-prompt--align-left ::v-deep(.ec-activator .v-btn) {
165165
left: 0;
166166
}
167167
168-
.ec-popover-prompt--align-right ::v-deep .ec-activator .v-btn {
168+
.ec-popover-prompt--align-right ::v-deep(.ec-activator .v-btn) {
169169
right: 0;
170170
}
171171
172-
.ec-popover-prompt--position-bottom ::v-deep .ec-activator .v-btn {
172+
.ec-popover-prompt--position-bottom ::v-deep(.ec-activator .v-btn) {
173173
bottom: 100%;
174174
border-bottom-right-radius: 0;
175175
border-bottom-left-radius: 0;
@@ -179,7 +179,7 @@ export default {
179179
0 3px 14px 2px rgba(0, 0, 0, 0.12);
180180
}
181181
182-
.ec-popover-prompt--position-top ::v-deep .ec-activator .v-btn {
182+
.ec-popover-prompt--position-top ::v-deep(.ec-activator .v-btn) {
183183
top: calc(100% - 10px);
184184
z-index: 10;
185185
border-top-right-radius: 0;

frontend/src/views/Profile.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export default {
116116
</script>
117117
118118
<style lang="scss" scoped>
119-
.e-profile--email ::v-deep .v-input__append-inner {
119+
.e-profile--email ::v-deep(.v-input__append-inner) {
120120
margin-top: 0 !important;
121121
align-self: center;
122122
}

0 commit comments

Comments
 (0)