From aae8a9dec49e10fda2488fabd4b7bcbf434e1e81 Mon Sep 17 00:00:00 2001 From: HiGregSmith Date: Mon, 20 Oct 2025 22:25:07 -0400 Subject: [PATCH 1/3] Update baseSlider.ts Added target and currentTarget properties to slider onValueChangedObservable. --- packages/dev/gui/src/2D/controls/sliders/baseSlider.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts b/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts index 62555c8e04a..e257fdee0b8 100644 --- a/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts +++ b/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts @@ -157,7 +157,7 @@ export class BaseSlider extends Control { this._value = value; this._markAsDirty(); - this.onValueChangedObservable.notifyObservers(this._value); + this.onValueChangedObservable.notifyObservers(this._value, undefined, this, this); } /**Gets or sets a boolean indicating if the slider should be vertical or horizontal */ @@ -342,3 +342,4 @@ export class BaseSlider extends Control { super._onCanvasBlur(); } } + From 7e1a3da4f181ac3a5f05b5fea50b9a10c3b581c0 Mon Sep 17 00:00:00 2001 From: HiGregSmith Date: Mon, 20 Oct 2025 23:10:40 -0400 Subject: [PATCH 2/3] Update baseSlider.ts removed final newline (was added by github) --- packages/dev/gui/src/2D/controls/sliders/baseSlider.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts b/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts index e257fdee0b8..a9a5b602758 100644 --- a/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts +++ b/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts @@ -326,7 +326,6 @@ export class BaseSlider extends Control { if (this._pointerIsDown && !this.isReadOnly) { this._updateValueFromPointer(coordinates.x, coordinates.y); } - super._onPointerMove(target, coordinates, pointerId, pi); } @@ -343,3 +342,4 @@ export class BaseSlider extends Control { } } + From 11d80edbf602231aa7532a4925f5bb641c7bd495 Mon Sep 17 00:00:00 2001 From: HiGregSmith Date: Mon, 20 Oct 2025 23:34:06 -0400 Subject: [PATCH 3/3] Update baseSlider.ts Removed final newline --- packages/dev/gui/src/2D/controls/sliders/baseSlider.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts b/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts index a9a5b602758..95adadf5b5e 100644 --- a/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts +++ b/packages/dev/gui/src/2D/controls/sliders/baseSlider.ts @@ -341,5 +341,3 @@ export class BaseSlider extends Control { super._onCanvasBlur(); } } - -