Skip to content

Commit 7d8ce87

Browse files
committed
Add a note that we need to think about the surface area default for fill_holes.
1 parent 82fddf5 commit 7d8ce87

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/libged/bot/manifold.cpp

+10-3
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,16 @@ geogram_mesh_repair(struct rt_bot_internal *bot)
178178
}
179179
}
180180

181-
// Do the hole filling, trying to fill all holes (1e30 is
182-
// a value used in the Geogram code for a large hole size -
183-
// there may be a better default...)
181+
// Do the hole filling.
182+
//
183+
// TODO: Right now we're basically trying to fill in ALL holes (1e30 is a
184+
// value used in the Geogram code for a large hole size. That large a value
185+
// may not be a good default for automatic processing - we might be better
186+
// off starting with something like a percentage of the surface area of the
187+
// mesh, so we don't end up "repairing" something with a giant hole in such
188+
// a way that it is unlikely to represent the original modeling intent. We
189+
// could then let the user override that default with something more
190+
// extreme manually if they deem the result useful.
184191
GEO::fill_holes(gm, 1e30);
185192

186193
// Make sure we're still repaired post filling

0 commit comments

Comments
 (0)