even if export succeeded, was possible to return and access uninit'd array.

init the bu_external right away and make it explicit during export also.

Author: brlcad

src/librt/binunif/db5_bin.c

@@ -207,11 +207,13 @@ rt_binunif_export5(struct bu_external		*ep,
     RT_CK_DB_INTERNAL(ip);
     bip = (struct rt_binunif_internal *)ip->idb_ptr;
     RT_CK_BINUNIF(bip);
-    if (bip->count <= 0)    /* nothing to convert */
-	return 0;
 
+    /* inputs valid, so init before return */
     BU_EXTERNAL_INIT(ep);
 
+    if (bip->count <= 0)    /* nothing to convert */
+	return 0;
+
     /*
      * Convert from internal (host) to database (network) format
      */
@@ -477,9 +479,9 @@ int
 rt_binunif_get(struct bu_vls *logstr, const struct rt_db_internal *intern, const char *attr)
 {
     register struct rt_binunif_internal *bip=(struct rt_binunif_internal *)intern->idb_ptr;
-    struct bu_external	ext;
-    size_t		i;
-    unsigned char	*c;
+    struct bu_external ext = BU_EXTERNAL_INIT_ZERO;
+    size_t i;
+    unsigned char *c;
 
     RT_CHECK_BINUNIF(bip);