Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Convert methods back in Engine #89

Open
alelom opened this issue May 20, 2020 · 0 comments
Open

Move Convert methods back in Engine #89

alelom opened this issue May 20, 2020 · 0 comments
Labels
good first issue Good for newcomers type:compliance Non-conforming to code guidelines

Comments

@alelom
Copy link
Member

alelom commented May 20, 2020

Broken rules:

Tl;dr: it can be useful to have Convert methods in the UI for the Engine in the Speckle_Toolkit, so they should be moved back in the Engine project.

Full description:

All Convert methods were moved in the Adapter project as a result of the latest compliance measures, intended to avoid exposing normally unneeded converts in the UI.

However, Speckle is as always a bit particular, and there are fringe cases where you might want to do the convert for certain objects in the UI, while explicitly avoiding the converts for others. For example, this allows to use the standard Speckle "Sender" component to upload native Rhino geometries together with BHoMObjects by separating them and avoiding having them to pass through a conversion phase all together. Complicated, but can be an extremely useful workaround in fringe situations.

Suggestions to restore compliance:

As above

@alelom alelom added type:compliance Non-conforming to code guidelines good first issue Good for newcomers labels May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:compliance Non-conforming to code guidelines
Projects
None yet
Development

No branches or pull requests

1 participant