Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create methods to be renamed "Convert" as what's they currently do #88

Open
alelom opened this issue May 20, 2020 · 0 comments
Open

Create methods to be renamed "Convert" as what's they currently do #88

alelom opened this issue May 20, 2020 · 0 comments
Labels
good first issue Good for newcomers type:compliance Non-conforming to code guidelines

Comments

@alelom
Copy link
Member

alelom commented May 20, 2020

Broken rules:

  • Create() methods currently just do a conversion to Speckle. This is a result of the troubled development. They should be put together with the Converts.

Suggestions to restore compliance:

Rename them
@alelom alelom added type:compliance Non-conforming to code guidelines good first issue Good for newcomers labels May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alelom