Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Read for a Delta (get Speckle Diffing) #56

Open
alelom opened this issue Feb 4, 2020 · 1 comment
Open

Implement the Read for a Delta (get Speckle Diffing) #56

alelom opened this issue Feb 4, 2020 · 1 comment
Assignees
Labels
severity:medium Slows progress, but workaround is possible type:feature New capability or enhancement

Comments

@alelom
Copy link
Member

alelom commented Feb 4, 2020

Description:

Currently Speckle already has an Endpoint to get the diff of two streams.
The current response is similar in format to the AEC deltas specification, but it will need to match it exactly.

As a first step, implement a Read that receives the current JSON diff format.

This will be simplified when the fork of SpeckleServer by @PaulPoinet will then implement the right Delta format.

Additional note

As feature requires a way for the user to specify the Stream Revisions to diff, this should be tackled together with #9

@alelom alelom added the type:feature New capability or enhancement label Feb 4, 2020
@alelom alelom self-assigned this Feb 4, 2020
@alelom alelom added the severity:medium Slows progress, but workaround is possible label Feb 4, 2020
@PaulPoinet
Copy link

This will be simplified when the fork of SpeckleServer by @PaulPoinet will then implement the right Delta format.

This is done and documented here.


The diffing response (between Revision_A and Revision_B) as specified in the REST API has been implemented here. Calling http://{server.com}/api/streams/{streamId}/delta/{streamId} produces the following response:

{
	"success": true,
	"revision_datetime": "2/4/2020, 4:15:41 PM",
	"autor": {
		"name": "Paul",
		"surname": "Poinet",
		"_id": "5dfa34188b094663fcd94381",
		"email": "[email protected]",
		"company": "UCL"
	},
	"delta": {
		"created": [530 items],
		"deleted": [],
		"common": [3401 items]
	},
	"revision_A": {
		"id": "Zt0Jg36lp",
		"updatedAt": "2/4/2020, 3:08:00 PM",
		"sender": "Grasshopper"
	},
	"revision_B": {
		"id": "F9UVibS-C",
		"updatedAt": "2/4/2020, 3:08:00 PM",
		"sender": "Grasshopper"
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:medium Slows progress, but workaround is possible type:feature New capability or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants