Fix Bug when Creating Bars in ETABS21 #483
Conversation
GCRA101
requested review from
IsakNaslundBh,
peterjamesnugent and
Chrisshort92
There was a problem hiding this comment.
If you're adding an alternate configuration, you will need to add it to the installer:
https://github.com/BHoM/BHoM_Installer/blob/develop/IncludedRepos/altConfigs.txt
| #if Debug21 == false && Release21 == false | ||
|
|
||
| if (m_model.FrameObj.SetInsertionPoint(name, (int)bhBar.InsertionPoint(), false, bhBar.ModifyStiffnessInsertionPoint(), ref offset1, ref offset2) != 0) | ||
| { | ||
| CreatePropertyWarning("Insertion point and perpendicular offset", "Bar", name); | ||
| ret++; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Does this actually work in practice? You can simplify the if statement, but just checking `#if Debug21' - VS has quite a good UI feature that highlights the code that is active dependent on the build configuration.
|
@peterjamesnugent, I've added the new ETABS 21 Release to the Installer. Below the link to the Pull Request |
|
@GCRA101 as discussed to add altconfigs to installer and update preprocessor directives to |
|
@BHoMBot check installer |
|
@Chrisshort92 to confirm, the following actions are now queued:
|
|
@BHoMBot Check Installer |
|
@Chrisshort92 to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #482
ETABS Toolkit now able to push bars to ETABS 21 by skipping not-working API function by using a new Debug21 Configuration.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23483-FixBugWhenCreatingBarsInETABS21/BHoM%207.3.1%20Test%20-%20Bar%20Object%20Push%20to%20ETABS%2021%201.gh?csf=1&web=1&e=LaeSMJ
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23483-FixBugWhenCreatingBarsInETABS21/Test%20ETABS%20Model.EDB?csf=1&web=1&e=boM6fg
Changelog