Add Adapter Support for Structure Openings #479
Conversation
GCRA101
requested review from
Chrisshort92,
peterjamesnugent and
IsakNaslundBh
|
@BHoMBot check required |
|
@Chrisshort92 to confirm, the following actions are now queued:
|
|
@BHoMBot check copyright-compliance |
|
@peterjamesnugent to confirm, the following actions are now queued:
There are 31 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@GCRA101 to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
There was a problem hiding this comment.
Do we need to add a dependency type of Panel as you would not push an Opening independently.
See here what we did for Lusas:
https://github.com/BHoM/Lusas_Toolkit/blob/24b2f3212ded178e410d8cdb36609d3001fd74f9/Lusas_Adapter/LusasAdapter.cs#L140
Equally, we need to update the code for Panel when you read it, that reads the Openings and assigns them appropriately.
Co-authored-by: Peter Nugent <[email protected]>
|
@GCRA101 have you added the dependency type for |
Issues addressed by this PR
Closes #375
ETABS Toolkit now allows to push and pull Opening objects.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23479-AddSupportForStructureOpenings/Test%20Script.gh?csf=1&web=1&e=fdeQlU
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23479-AddSupportForStructureOpenings/Test%20ETABS%20Model.EDB?csf=1&web=1&e=xXim64
Changelog