Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explode issues after changing the number of CustomObject properties #279

Open
pawelbaran opened this issue Dec 10, 2020 · 2 comments
Open
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

Description:

After removing one of the CustomObject properties and trying to update outputs of the Explode component, Dynamo crashes:
dynamo2

After removing one of the CustomObject properties and replacing the Explode component, output names do not match the values:
dynamo1

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Dec 10, 2020
@adecler
Copy link
Member

adecler commented Dec 15, 2020

I cannot make Dynamo crash repeating the step above but I do get the issue with mismatched inputs. The problem is on the CustomObject component itself (as confirmed by the ToJson and new Explode components), not on the Explode. Although I don't know why Explode also complains. I will have a look.

image

@adecler
Copy link
Member

adecler commented Dec 15, 2020

After spending some time with this, I still don't know how to fix it.
Dynamo itself passes the wrong inputs to BuildOutputAst once the user has removed an input. A copy/pasted component is corrected and works fine though so there must be some command we can send Dynamo to properly fix this. After trying a few things like MarxkComponentAsModified without success I decided this is something I am not happy to spend more time on right now so it will have to wait. Thankfully this is a bug that has a few ways to get around so I guess Dynamo users are used to have to do that.

@adecler adecler removed their assignment Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants