Skip to content

Commit a5ea4bf

Browse files
[formrecognizer] Add a default for percent_completed (Azure#22790)
Default percent_completed to 0. After talking to the service team, this should be defaulted to 0 when not returned. Generally our tests fail with operations that have a `notStarted` status since this is currently not returning a percent_completed value.
1 parent 74e7d3d commit a5ea4bf

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sdk/formrecognizer/azure-ai-formrecognizer/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
### Breaking Changes
88

99
### Bugs Fixed
10+
- Default the `percent_completed` property to 0 when not returned with model operation information.
1011

1112
### Other Changes
1213
- Python 2.7 is no longer supported in this release. Please use Python 3.6 or later.

sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3257,7 +3257,7 @@ class ModelOperationInfo(object):
32573257
def __init__(self, **kwargs):
32583258
self.operation_id = kwargs.get("operation_id", None)
32593259
self.status = kwargs.get("status", None)
3260-
self.percent_completed = kwargs.get("percent_completed", None)
3260+
self.percent_completed = kwargs.get("percent_completed", 0)
32613261
self.created_on = kwargs.get("created_on", None)
32623262
self.last_updated_on = kwargs.get("last_updated_on", None)
32633263
self.kind = kwargs.get("kind", None)
@@ -3318,7 +3318,7 @@ def _from_generated(cls, op):
33183318
return cls(
33193319
operation_id=op.operation_id,
33203320
status=op.status,
3321-
percent_completed=op.percent_completed,
3321+
percent_completed=op.percent_completed if op.percent_completed else 0,
33223322
created_on=op.created_date_time,
33233323
last_updated_on=op.last_updated_date_time,
33243324
kind=op.kind,
@@ -3425,7 +3425,7 @@ def _from_generated(cls, op, api_version): # pylint: disable=arguments-differ
34253425
return cls(
34263426
operation_id=op.operation_id,
34273427
status=op.status,
3428-
percent_completed=op.percent_completed,
3428+
percent_completed=op.percent_completed if op.percent_completed else 0,
34293429
created_on=op.created_date_time,
34303430
last_updated_on=op.last_updated_date_time,
34313431
kind=op.kind,

0 commit comments

Comments
 (0)