Changing to cx subscription for faster execution of MI tests (Azure#24691)

* Changing to cx subscription for faster execution of MI tests

* few more tests fixed

* More tests recorded and fixed

* fixing FOG test

* Fixing VA tests

* One more try with these tests

* revert wrong files

* Fixing secretes

Co-authored-by: Milan Brkic <[email protected]>

Author: milanbrkic-ms

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/InstanceFailoverGroupCrudScenarioTests.cs

@@ -26,10 +26,10 @@ public void TestCrudInstanceFailoverGroup()
                 SqlManagementClient sqlClient = context.GetClient<SqlManagementClient>();
 
                 // Names of pre-existing ManagedInstances
-                string sourceManagedInstanceName = "tdstage-haimb-dont-delete-3";
-                string targetManagedInstanceName = "threat-detection-test-1";
-                string sourceResourceGroup = "testclrg";
-                string targetResourceGroup = "testclrg";
+                string sourceManagedInstanceName = "mi-primary-wcus";
+                string targetManagedInstanceName = "mi-tooling-cus";
+                string sourceResourceGroup = ManagedInstanceTestUtilities.ResourceGroupName;
+                string targetResourceGroup = ManagedInstanceTestUtilities.ResourceGroupName;
 
                 // Create server 
                 var sourceManagedInstance = sqlClient.ManagedInstances.Get(sourceResourceGroup, sourceManagedInstanceName);

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/InstancePoolCrudScenarioTests.cs

@@ -11,7 +11,7 @@ namespace Sql.Tests
 {
     public class InstancePoolCrudScenarioTests
     {
-        [Fact]
+        [Fact(Skip = "Due long running setup")]
         public void TestCreateUpdateGetDropInstancePool()
         {
             using (SqlManagementTestContext context = new SqlManagementTestContext(this))
@@ -114,11 +114,11 @@ public void TestCreateUpdateGetDropInstancePool()
 
                 // Create instance 1 in pool
                 var instance1 = sqlClient.ManagedInstances.CreateOrUpdate(resourceGroupName, "netsdk-instance-in-pool-1-cc", parameters: instanceParams);
-                SqlManagementTestUtilities.ValidateManagedInstance(instance1, "netsdk-instance-in-pool-1-cc", "cloudsa", tags1, location, instancePool.Id);
+                SqlManagementTestUtilities.ValidateManagedInstance(instance1, tags: tags1, instancePoolId: instancePool.Id);
 
                 // Create instance 2 in pool
                 var instance2 = sqlClient.ManagedInstances.CreateOrUpdate(resourceGroupName, "netsdk-instance-in-pool-2-cc", parameters: instanceParams);
-                SqlManagementTestUtilities.ValidateManagedInstance(instance2, "netsdk-instance-in-pool-2-cc", "cloudsa", tags1, location, instancePool.Id);
+                SqlManagementTestUtilities.ValidateManagedInstance(instance2, tags: tags1, instancePoolId: instancePool.Id);
 
                 // Gets instances in an instance pool
                 var instances = sqlClient.ManagedInstances.ListByInstancePool(resourceGroupName, instancePoolName);

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/ManagedDatabaseCrudScenarioTests.cs

@@ -23,11 +23,10 @@ public void TestCreateDropManagedDatabase()
 
                 // Update with values from a current MI on the region
                 //
-                string resourceGroup = "testclrg";
-                string managedInstanceName = "tdstage-haimb-dont-delete-3";
+                var resourceGroup = context.CreateResourceGroup(ManagedInstanceTestUtilities.Region);
 
                 //Get MI
-                var managedInstance = sqlClient.ManagedInstances.Get(resourceGroup, managedInstanceName);
+                var managedInstance = context.CreateManagedInstance(resourceGroup);
 
                 Dictionary<string, string> tags = new Dictionary<string, string>()
                     {
@@ -37,7 +36,7 @@ public void TestCreateDropManagedDatabase()
                 // Create database only required parameters
                 //
                 string mdbName = SqlManagementTestUtilities.GenerateName();
-                var mdb1 = sqlClient.ManagedDatabases.CreateOrUpdate(resourceGroup, managedInstance.Name, mdbName, new ManagedDatabase()
+                var mdb1 = sqlClient.ManagedDatabases.CreateOrUpdate(resourceGroup.Name, managedInstance.Name, mdbName, new ManagedDatabase()
                 {
                     Location = managedInstance.Location,
                 });
@@ -53,12 +52,12 @@ public void TestCreateDropManagedDatabase()
                     Tags = tags,
                     CreateMode = "Default"
                 };
-                var mdb2 = sqlClient.ManagedDatabases.CreateOrUpdate(resourceGroup, managedInstance.Name, mdbName, mdb2Input);
+                var mdb2 = sqlClient.ManagedDatabases.CreateOrUpdate(resourceGroup.Name, managedInstance.Name, mdbName, mdb2Input);
                 Assert.NotNull(mdb2);
                 SqlManagementTestUtilities.ValidateManagedDatabase(mdb2Input, mdb2, mdbName);
 
-                sqlClient.ManagedDatabases.Delete(resourceGroup, managedInstance.Name, mdb1.Name);
-                sqlClient.ManagedDatabases.Delete(resourceGroup, managedInstance.Name, mdb2.Name);
+                sqlClient.ManagedDatabases.Delete(resourceGroup.Name, managedInstance.Name, mdb1.Name);
+                sqlClient.ManagedDatabases.Delete(resourceGroup.Name, managedInstance.Name, mdb2.Name);
             }
         }
 
@@ -71,17 +70,12 @@ public void TestGetAndListManagedDatabase()
             {
                 SqlManagementClient sqlClient = context.GetClient<SqlManagementClient>();
 
-                // Update with values from a current MI on the region
-                //
-                string resourceGroup = "testclrg";
-                string managedInstanceName = "tdstage-haimb-dont-delete-3";
-
-                // Get MI
-                var managedInstance = sqlClient.ManagedInstances.Get(resourceGroup, managedInstanceName);
+                var resourceGroup = context.CreateResourceGroup(ManagedInstanceTestUtilities.Region);
+                var managedInstance = context.CreateManagedInstance(resourceGroup);
 
                 // Create some small databases to run the get/List tests on.
                 ManagedDatabase[] mngdDatabases = SqlManagementTestUtilities.CreateManagedDatabasesAsync(
-                    sqlClient, resourceGroup, managedInstance, testPrefix, 4).Result;
+                    sqlClient, resourceGroup.Name, managedInstance, testPrefix, 4).Result;
 
                 // Organize into a dictionary for better lookup later
                 IDictionary<string, ManagedDatabase> inputs = mngdDatabases.ToDictionary(
@@ -92,13 +86,13 @@ public void TestGetAndListManagedDatabase()
                 //
                 foreach (var db in inputs)
                 {
-                    var response = sqlClient.ManagedDatabases.Get(resourceGroup, managedInstance.Name, db.Key);
+                    var response = sqlClient.ManagedDatabases.Get(resourceGroup.Name, managedInstance.Name, db.Key);
                     SqlManagementTestUtilities.ValidateManagedDatabaseEx(db.Value, response);
                 }
 
                 // List all databases
                 //
-                var listResponse = sqlClient.ManagedDatabases.ListByInstance(resourceGroup, managedInstance.Name);
+                var listResponse = sqlClient.ManagedDatabases.ListByInstance(resourceGroup.Name, managedInstance.Name);
 
                 // Check that all created Managed Databases are created
                 foreach (var db in inputs.Keys)
@@ -111,7 +105,7 @@ public void TestGetAndListManagedDatabase()
 
                 foreach (var db in inputs.Keys)
                 {
-                    sqlClient.ManagedDatabases.Delete(resourceGroup, managedInstance.Name, db);
+                    sqlClient.ManagedDatabases.Delete(resourceGroup.Name, managedInstance.Name, db);
                 }
 
             }

sdk/sqlmanagement/Microsoft.Azure.Management.Sql/tests/ManagedDatabaseRestoreScenarioTests.cs

@@ -2,16 +2,15 @@
 using Microsoft.Azure.Management.ResourceManager.Models;
 using Microsoft.Azure.Management.Sql;
 using Microsoft.Azure.Management.Sql.Models;
-using Microsoft.Azure.Management.Network.Models;
 using Microsoft.Azure.Test.HttpRecorder;
-using Sku = Microsoft.Azure.Management.Sql.Models.Sku;
 using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
 using Xunit;
-using Microsoft.Rest;
-using System.Net;
+using Microsoft.Azure.Management.Storage;
+using Microsoft.WindowsAzure.Storage.Blob;
+using Microsoft.Azure.Management.Storage.Models;
 
 namespace Sql.Tests
 {
@@ -26,7 +25,7 @@ public void ShortTermRetentionOnLiveDatabase()
             {
                 SqlManagementClient sqlClient = Context.GetClient<SqlManagementClient>();
                 ResourceGroup resourceGroup = Context.CreateResourceGroup();
-                ManagedInstance managedInstance = CreateManagedInstance(Context, sqlClient, resourceGroup, "ShortTermRetentionOnLiveDatabase");
+                ManagedInstance managedInstance = Context.CreateManagedInstance(resourceGroup);
 
                 // Create managed database
                 //
@@ -38,7 +37,7 @@ public void ShortTermRetentionOnLiveDatabase()
                 Assert.NotNull(db1);
 
                 int basicRetention = 7;
-                int invalidValue = 3;
+                int smallValue = 3;
                 int validValue = 20;
 
                 // Attempt to increase retention period to 7 days and verfiy that the operation succeeded.
@@ -48,12 +47,12 @@ public void ShortTermRetentionOnLiveDatabase()
                 ManagedBackupShortTermRetentionPolicy policy = sqlClient.ManagedBackupShortTermRetentionPolicies.Get(resourceGroup.Name, managedInstance.Name, dbName);
                 Assert.Equal(basicRetention, policy.RetentionDays);
 
-                // Attempt to increase retention period to 3 days and verfiy that the operation fails.
-                ManagedBackupShortTermRetentionPolicy parameters1 = new ManagedBackupShortTermRetentionPolicy(retentionDays: invalidValue);
+                // Attempt to decrease retention period to 3 days and verfiy that the operation succeeded.
+                ManagedBackupShortTermRetentionPolicy parameters1 = new ManagedBackupShortTermRetentionPolicy(retentionDays: smallValue);
                 sqlClient.ManagedBackupShortTermRetentionPolicies.CreateOrUpdateWithHttpMessagesAsync(resourceGroup.Name, managedInstance.Name, dbName, parameters1);
                 Microsoft.Rest.ClientRuntime.Azure.TestFramework.TestUtilities.Wait(TimeSpan.FromSeconds(3));
                 policy = sqlClient.ManagedBackupShortTermRetentionPolicies.Get(resourceGroup.Name, managedInstance.Name, dbName);
-                Assert.Equal(basicRetention, policy.RetentionDays);
+                Assert.Equal(smallValue, policy.RetentionDays);
 
                 // Attempt to increase retention period to 20 days and verfiy that the operation succeeded .
                 ManagedBackupShortTermRetentionPolicy parameters2 = new ManagedBackupShortTermRetentionPolicy(retentionDays: validValue);
@@ -71,7 +70,7 @@ public void ShortTermRetentionOnDroppedDatabase()
             {
                 SqlManagementClient sqlClient = Context.GetClient<SqlManagementClient>();
                 ResourceGroup resourceGroup = Context.CreateResourceGroup();
-                ManagedInstance managedInstance = CreateManagedInstance(Context, sqlClient, resourceGroup, "ShortTermRetentionOnDroppedDatabase");
+                ManagedInstance managedInstance = Context.CreateManagedInstance(resourceGroup);
 
                 // Create managed database
                 //
@@ -158,7 +157,7 @@ public void RestorableDroppedManagedDatabasesTests()
             {
                 SqlManagementClient sqlClient = Context.GetClient<SqlManagementClient>();
                 ResourceGroup resourceGroup = Context.CreateResourceGroup();
-                ManagedInstance managedInstance = CreateManagedInstance(Context, sqlClient, resourceGroup, "RestorableDroppedManagedDatabasesTests");
+                ManagedInstance managedInstance = Context.CreateManagedInstance(resourceGroup);
 
                 // Create managed database
                 //
@@ -270,11 +269,31 @@ public void ManagedDatabaseExternalBackupRestoreTest()
             using (SqlManagementTestContext Context = new SqlManagementTestContext(this))
             {
                 SqlManagementClient sqlClient = Context.GetClient<SqlManagementClient>();
-                ResourceGroup resourceGroup = Context.CreateResourceGroup();
-                ManagedInstance managedInstance = CreateManagedInstance(Context, sqlClient, resourceGroup);
+                StorageManagementClient storageClient = Context.GetClient<StorageManagementClient>();
+                const string AccountName = "backupscxteam";
+
+                string testStorageContainerUri = "https://backupscxteam.blob.core.windows.net/clients";
+                string testStorageContainerSasToken = string.Empty;
+                StorageAccountListKeysResult keys =
+                    storageClient.StorageAccounts.ListKeys(ManagedInstanceTestUtilities.ResourceGroupName, AccountName);
+                string key = keys.Keys.First().Value;
 
-                string testStorageContainerUri = "https://misosictest1.blob.core.windows.net/striped-inc";
-                string testStorageContainerSasToken = "?sv=2018-03-28&ss=bfqt&srt=co&sp=rl&se=2021-10-07T20:57:18Z&st=2019-10-07T12:57:18Z&spr=https&sig=wUFmxnyiCglm9U9%2B3VaPW0YlXFpvn%2BkGc%2B5wesmwWuU%3D";
+                if (HttpMockServer.Mode == HttpRecorderMode.Record)
+                {
+
+                    CloudBlobContainer container = new CloudBlobContainer(
+                        new Uri(testStorageContainerUri),
+                        new Microsoft.WindowsAzure.Storage.Auth.StorageCredentials(AccountName, key));
+                    SharedAccessBlobPolicy sharedAccessPolicy = new SharedAccessBlobPolicy
+                    {
+                        SharedAccessExpiryTime = new DateTimeOffset(DateTime.UtcNow.Add(TimeSpan.FromHours(1))),
+                        Permissions = SharedAccessBlobPermissions.Read | SharedAccessBlobPermissions.List
+                    };
+                    testStorageContainerSasToken = container.GetSharedAccessSignature(sharedAccessPolicy);
+                }
+
+                ResourceGroup resourceGroup = Context.CreateResourceGroup();
+                ManagedInstance managedInstance = Context.CreateManagedInstance(resourceGroup);
                 string databaseName = SqlManagementTestUtilities.GenerateName(_testPrefix);
 
                 // Start external backup restore.
@@ -333,7 +352,7 @@ public void ManagedDatabaseExternalBackupRestoreTest()
                     // No need to sleep if we are playing back the recording.
                     if (HttpMockServer.Mode == HttpRecorderMode.Record)
                     {
-                        Thread.Sleep(TimeSpan.FromSeconds(30));
+                        Thread.Sleep(TimeSpan.FromSeconds(60));
                     }
 
                     return false;
@@ -373,28 +392,6 @@ public void ManagedDatabaseExternalBackupRestoreTest()
 
         private const string _testPrefix = "manageddatabaserestorescenariotest-";
 
-        private ManagedInstance CreateManagedInstance(SqlManagementTestContext context, SqlManagementClient sqlClient, ResourceGroup resourceGroup, string callingMethodName = "CreateManagedInstance")
-        {
-            // Create vnet and get the subnet id
-            VirtualNetwork vnet = ManagedInstanceTestFixture.CreateVirtualNetwork(context, resourceGroup, TestEnvironmentUtilities.DefaultLocationId);
-
-            Sku sku = new Sku();
-            sku.Name = "MIGP8G4";
-            sku.Tier = "GeneralPurpose";
-            ManagedInstance managedInstance = sqlClient.ManagedInstances.CreateOrUpdate(resourceGroup.Name,
-                _testPrefix + SqlManagementTestUtilities.GenerateName(methodName: callingMethodName), new ManagedInstance()
-                {
-                    AdministratorLogin = SqlManagementTestUtilities.DefaultLogin,
-                    AdministratorLoginPassword = SqlManagementTestUtilities.DefaultPassword,
-                    Sku = sku,
-                    SubnetId = vnet.Subnets[0].Id,
-                    Tags = new Dictionary<string, string>(),
-                    Location = TestEnvironmentUtilities.DefaultLocationId,
-                });
-
-            return managedInstance;
-        }
-
         private void RetryAction(Func<bool> action, int timeoutInMin = 15)
         {
             DateTime startTime = DateTime.UtcNow;