[MetricsAdvisor] Updated disposable test types to return whole created model (Azure#21781)

Author: kinelski

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/DisposableAlertConfiguration.cs

@@ -5,7 +5,6 @@
 using System.Threading.Tasks;
 using Azure.AI.MetricsAdvisor.Administration;
 using Azure.AI.MetricsAdvisor.Models;
-using NUnit.Framework;
 
 namespace Azure.AI.MetricsAdvisor.Tests
 {
@@ -25,39 +24,35 @@ public class DisposableAlertConfiguration : IAsyncDisposable
         /// Initializes a new instance of the <see cref="DisposableAlertConfiguration"/> class.
         /// </summary>
         /// <param name="adminClient">The client to use for deleting the configuration upon disposal.</param>
-        /// <param name="id">The identifier of the alert configuration this instance is associated with.</param>
-        private DisposableAlertConfiguration(MetricsAdvisorAdministrationClient adminClient, string id)
+        /// <param name="configuration">The alert configuration this instance is associated with.</param>
+        private DisposableAlertConfiguration(MetricsAdvisorAdministrationClient adminClient, AnomalyAlertConfiguration configuration)
         {
             _adminClient = adminClient;
-            Id = id;
+            Configuration = configuration;
         }
 
         /// <summary>
-        /// The identifier of the alert configuration this instance is associated with.
+        /// The alert configuration this instance is associated with.
         /// </summary>
-        public string Id { get; }
+        public AnomalyAlertConfiguration Configuration { get; }
 
         /// <summary>
         /// Creates an alert configuration using the specified <see cref="MetricsAdvisorAdministrationClient"/>.
-        /// A <see cref="DisposableAlertConfiguration"/> instance is returned, from which the ID of the created
-        /// configuration can be obtained. Upon disposal, the associated configuration will be deleted.
+        /// A <see cref="DisposableAlertConfiguration"/> instance is returned, from which the created configuration
+        /// can be obtained. Upon disposal, the associated configuration will be deleted.
         /// </summary>
         /// <param name="adminClient">The client to use for creating and for deleting the configuration.</param>
-        /// <param name="hook">Specifies how the created <see cref="AnomalyAlertConfiguration"/> should be configured.</param>
-        /// <returns>A <see cref="DisposableAlertConfiguration"/> instance from which the ID of the created configuration can be obtained.</returns>
+        /// <param name="configuration">Specifies how the created <see cref="AnomalyAlertConfiguration"/> should be configured.</param>
+        /// <returns>A <see cref="DisposableAlertConfiguration"/> instance from which the created configuration can be obtained.</returns>
         public static async Task<DisposableAlertConfiguration> CreateAlertConfigurationAsync(MetricsAdvisorAdministrationClient adminClient, AnomalyAlertConfiguration alertConfiguration)
         {
             AnomalyAlertConfiguration createdConfig = await adminClient.CreateAlertConfigurationAsync(alertConfiguration);
-
-            Assert.That(createdConfig, Is.Not.Null);
-            Assert.That(createdConfig.Id, Is.Not.Null.And.Not.Empty);
-
-            return new DisposableAlertConfiguration(adminClient, createdConfig.Id);
+            return new DisposableAlertConfiguration(adminClient, createdConfig);
         }
 
         /// <summary>
         /// Deletes the configuration this instance is associated with.
         /// </summary>
-        public async ValueTask DisposeAsync() => await _adminClient.DeleteAlertConfigurationAsync(Id);
+        public async ValueTask DisposeAsync() => await _adminClient.DeleteAlertConfigurationAsync(Configuration.Id);
     }
 }

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/DisposableDataFeed.cs

@@ -5,12 +5,11 @@
 using System.Threading.Tasks;
 using Azure.AI.MetricsAdvisor.Administration;
 using Azure.AI.MetricsAdvisor.Models;
-using NUnit.Framework;
 
 namespace Azure.AI.MetricsAdvisor.Tests
 {
     /// <summary>
-    /// Represents a <see cref="DataFeed"/> that has been created for testing purposes. In order to
+    /// Represents a <see cref="Models.DataFeed"/> that has been created for testing purposes. In order to
     /// create a new instance of this class, the <see cref="CreateDataFeedAsync"/> static method must
     /// be invoked. The created data feed will be deleted upon disposal.
     /// </summary>

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/DisposableDatasourceCredential.cs

@@ -5,7 +5,6 @@
 using System.Threading.Tasks;
 using Azure.AI.MetricsAdvisor.Administration;
 using Azure.AI.MetricsAdvisor.Models;
-using NUnit.Framework;
 
 namespace Azure.AI.MetricsAdvisor.Tests
 {
@@ -48,10 +47,6 @@ private DisposableDatasourceCredential(MetricsAdvisorAdministrationClient adminC
         public static async Task<DisposableDatasourceCredential> CreateDatasourceCredentialAsync(MetricsAdvisorAdministrationClient adminClient, DatasourceCredential credential)
         {
             DatasourceCredential createdCredential = await adminClient.CreateDatasourceCredentialAsync(credential);
-
-            Assert.That(createdCredential, Is.Not.Null);
-            Assert.That(createdCredential.Id, Is.Not.Null.And.Not.Empty);
-
             return new DisposableDatasourceCredential(adminClient, createdCredential);
         }
 

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/DisposableDetectionConfiguration.cs

@@ -5,7 +5,6 @@
 using System.Threading.Tasks;
 using Azure.AI.MetricsAdvisor.Administration;
 using Azure.AI.MetricsAdvisor.Models;
-using NUnit.Framework;
 
 namespace Azure.AI.MetricsAdvisor.Tests
 {
@@ -25,39 +24,35 @@ public class DisposableDetectionConfiguration : IAsyncDisposable
         /// Initializes a new instance of the <see cref="DisposableDetectionConfiguration"/> class.
         /// </summary>
         /// <param name="adminClient">The client to use for deleting the configuration upon disposal.</param>
-        /// <param name="id">The identifier of the detection configuration this instance is associated with.</param>
-        private DisposableDetectionConfiguration(MetricsAdvisorAdministrationClient adminClient, string id)
+        /// <param name="configuration">The detection configuration this instance is associated with.</param>
+        private DisposableDetectionConfiguration(MetricsAdvisorAdministrationClient adminClient, AnomalyDetectionConfiguration configuration)
         {
             _adminClient = adminClient;
-            Id = id;
+            Configuration = configuration;
         }
 
         /// <summary>
-        /// The identifier of the detection configuration this instance is associated with.
+        /// The detection configuration this instance is associated with.
         /// </summary>
-        public string Id { get; }
+        public AnomalyDetectionConfiguration Configuration { get; }
 
         /// <summary>
         /// Creates a detection configuration using the specified <see cref="MetricsAdvisorAdministrationClient"/>.
-        /// A <see cref="DisposableDetectionConfiguration"/> instance is returned, from which the ID of the created
-        /// configuration can be obtained. Upon disposal, the associated configuration will be deleted.
+        /// A <see cref="DisposableDetectionConfiguration"/> instance is returned, from which the created configuration
+        /// can be obtained. Upon disposal, the associated configuration will be deleted.
         /// </summary>
         /// <param name="adminClient">The client to use for creating and for deleting the configuration.</param>
-        /// <param name="hook">Specifies how the created <see cref="AnomalyDetectionConfiguration"/> should be configured.</param>
-        /// <returns>A <see cref="DisposableDetectionConfiguration"/> instance from which the ID of the created configuration can be obtained.</returns>
-        public static async Task<DisposableDetectionConfiguration> CreateDetectionConfigurationAsync(MetricsAdvisorAdministrationClient adminClient, AnomalyDetectionConfiguration detectionConfiguration)
+        /// <param name="configuration">Specifies how the created <see cref="AnomalyDetectionConfiguration"/> should be configured.</param>
+        /// <returns>A <see cref="DisposableDetectionConfiguration"/> instance from which the created configuration can be obtained.</returns>
+        public static async Task<DisposableDetectionConfiguration> CreateDetectionConfigurationAsync(MetricsAdvisorAdministrationClient adminClient, AnomalyDetectionConfiguration configuration)
         {
-            AnomalyDetectionConfiguration createdConfig = await adminClient.CreateDetectionConfigurationAsync(detectionConfiguration);
-
-            Assert.That(createdConfig, Is.Not.Null);
-            Assert.That(createdConfig.Id, Is.Not.Null.And.Not.Empty);
-
-            return new DisposableDetectionConfiguration(adminClient, createdConfig.Id);
+            AnomalyDetectionConfiguration createdConfig = await adminClient.CreateDetectionConfigurationAsync(configuration);
+            return new DisposableDetectionConfiguration(adminClient, createdConfig);
         }
 
         /// <summary>
         /// Deletes the configuration this instance is associated with.
         /// </summary>
-        public async ValueTask DisposeAsync() => await _adminClient.DeleteDetectionConfigurationAsync(Id);
+        public async ValueTask DisposeAsync() => await _adminClient.DeleteDetectionConfigurationAsync(Configuration.Id);
     }
 }

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/DisposableNotificationHook.cs

@@ -5,7 +5,6 @@
 using System.Threading.Tasks;
 using Azure.AI.MetricsAdvisor.Administration;
 using Azure.AI.MetricsAdvisor.Models;
-using NUnit.Framework;
 
 namespace Azure.AI.MetricsAdvisor.Tests
 {
@@ -25,39 +24,35 @@ public class DisposableNotificationHook : IAsyncDisposable
         /// Initializes a new instance of the <see cref="DisposableNotificationHook"/> class.
         /// </summary>
         /// <param name="adminClient">The client to use for deleting the hook upon disposal.</param>
-        /// <param name="id">The identifier of the hook this instance is associated with.</param>
-        private DisposableNotificationHook(MetricsAdvisorAdministrationClient adminClient, string id)
+        /// <param name="hook">The hook this instance is associated with.</param>
+        private DisposableNotificationHook(MetricsAdvisorAdministrationClient adminClient, NotificationHook hook)
         {
             _adminClient = adminClient;
-            Id = id;
+            Hook = hook;
         }
 
         /// <summary>
-        /// The identifier of the hook this instance is associated with.
+        /// The hook this instance is associated with.
         /// </summary>
-        public string Id { get; }
+        public NotificationHook Hook { get; }
 
         /// <summary>
         /// Creates a hook using the specified <see cref="MetricsAdvisorAdministrationClient"/>. A
-        /// <see cref="DisposableNotificationHook"/> instance is returned, from which the ID of the
-        /// created hook can be obtained. Upon disposal, the associated hook will be deleted.
+        /// <see cref="DisposableNotificationHook"/> instance is returned, from which the created
+        /// hook can be obtained. Upon disposal, the associated hook will be deleted.
         /// </summary>
         /// <param name="adminClient">The client to use for creating and for deleting the hook.</param>
         /// <param name="hook">Specifies how the created <see cref="NotificationHook"/> should be configured.</param>
-        /// <returns>A <see cref="DisposableNotificationHook"/> instance from which the ID of the created hook can be obtained.</returns>
+        /// <returns>A <see cref="DisposableNotificationHook"/> instance from which the created hook can be obtained.</returns>
         public static async Task<DisposableNotificationHook> CreateHookAsync(MetricsAdvisorAdministrationClient adminClient, NotificationHook hook)
         {
             NotificationHook createdHook = await adminClient.CreateHookAsync(hook);
-
-            Assert.That(createdHook, Is.Not.Null);
-            Assert.That(createdHook.Id, Is.Not.Null.And.Not.Empty);
-
-            return new DisposableNotificationHook(adminClient, createdHook.Id);
+            return new DisposableNotificationHook(adminClient, createdHook);
         }
 
         /// <summary>
         /// Deletes the hook this instance is associated with.
         /// </summary>
-        public async ValueTask DisposeAsync() => await _adminClient.DeleteHookAsync(Id);
+        public async ValueTask DisposeAsync() => await _adminClient.DeleteHookAsync(Hook.Id);
     }
 }