Simple overload for StartTranslation (Azure#19557)

Author: a-noyass

sdk/documenttranslation/Azure.AI.DocumentTranslation/api/Azure.AI.DocumentTranslation.netstandard2.0.cs

@@ -36,10 +36,10 @@ public DocumentTranslationClient(System.Uri endpoint, Azure.Core.TokenCredential
         public override int GetHashCode() { throw null; }
         public virtual Azure.Pageable<Azure.AI.DocumentTranslation.TranslationStatusDetail> GetTranslations(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
         public virtual Azure.AsyncPageable<Azure.AI.DocumentTranslation.TranslationStatusDetail> GetTranslationsAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public virtual Azure.AI.DocumentTranslation.DocumentTranslationOperation StartTranslation(Azure.AI.DocumentTranslation.TranslationConfiguration configuration, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
         public virtual Azure.AI.DocumentTranslation.DocumentTranslationOperation StartTranslation(System.Collections.Generic.IEnumerable<Azure.AI.DocumentTranslation.TranslationConfiguration> configurations, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual Azure.AI.DocumentTranslation.DocumentTranslationOperation StartTranslation(System.Uri sourceBlobContainerSas, System.Uri targetBlobContainerSas, string targetLanguageCode, Azure.AI.DocumentTranslation.TranslationGlossary glossary = null, Azure.AI.DocumentTranslation.TranslationOperationOptions options = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public virtual System.Threading.Tasks.Task<Azure.AI.DocumentTranslation.DocumentTranslationOperation> StartTranslationAsync(Azure.AI.DocumentTranslation.TranslationConfiguration configuration, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
         public virtual System.Threading.Tasks.Task<Azure.AI.DocumentTranslation.DocumentTranslationOperation> StartTranslationAsync(System.Collections.Generic.IEnumerable<Azure.AI.DocumentTranslation.TranslationConfiguration> configurations, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.AI.DocumentTranslation.DocumentTranslationOperation> StartTranslationAsync(System.Uri sourceBlobContainerSas, System.Uri targetBlobContainerSas, string targetLanguageCode, Azure.AI.DocumentTranslation.TranslationGlossary glossary = null, Azure.AI.DocumentTranslation.TranslationOperationOptions options = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
         public override string ToString() { throw null; }
     }
@@ -157,9 +157,11 @@ protected PageableOperation() { }
     public partial class TranslationConfiguration
     {
         public TranslationConfiguration(Azure.AI.DocumentTranslation.TranslationSource source, System.Collections.Generic.IEnumerable<Azure.AI.DocumentTranslation.TranslationTarget> targets) { }
+        public TranslationConfiguration(System.Uri sourceUri, System.Uri targetUri, string targetLanguageCode, Azure.AI.DocumentTranslation.TranslationGlossary glossary = null) { }
         public Azure.AI.DocumentTranslation.TranslationSource Source { get { throw null; } }
         public Azure.AI.DocumentTranslation.StorageType? StorageType { get { throw null; } set { } }
         public System.Collections.Generic.IList<Azure.AI.DocumentTranslation.TranslationTarget> Targets { get { throw null; } }
+        public void AddTarget(System.Uri targetUri, string languageCode, Azure.AI.DocumentTranslation.TranslationGlossary glossary = null) { }
     }
     public partial class TranslationGlossary
     {
@@ -168,14 +170,6 @@ public TranslationGlossary(System.Uri glossaryUri) { }
         public System.Uri GlossaryUri { get { throw null; } }
         public string Version { get { throw null; } set { } }
     }
-    public partial class TranslationOperationOptions
-    {
-        public TranslationOperationOptions() { }
-        public string Category { get { throw null; } set { } }
-        public Azure.AI.DocumentTranslation.DocumentFilter Filter { get { throw null; } set { } }
-        public string SourceLanguage { get { throw null; } set { } }
-        public Azure.AI.DocumentTranslation.StorageType? StorageType { get { throw null; } set { } }
-    }
     public partial class TranslationSource
     {
         public TranslationSource(System.Uri sourceUri) { }

sdk/documenttranslation/Azure.AI.DocumentTranslation/src/DocumentTranslationClient.cs

@@ -106,7 +106,7 @@ public DocumentTranslationClient(Uri endpoint, AzureKeyCredential credential)
         /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/document-translation/overview"/>.
         /// </summary>
         /// <param name="configurations">Sets the configurations for the translation operation
-        /// including source and target storage for documents to be translated. </param>
+        /// including source and target containers for documents to be translated. </param>
         /// <param name="cancellationToken">A <see cref="CancellationToken"/> controlling the request lifetime.</param>
         /// <exception cref="RequestFailedException">Service returned a non-success status code. </exception>
         public virtual DocumentTranslationOperation StartTranslation(IEnumerable<TranslationConfiguration> configurations, CancellationToken cancellationToken = default)
@@ -133,7 +133,7 @@ public virtual DocumentTranslationOperation StartTranslation(IEnumerable<Transla
         /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/document-translation/overview"/>.
         /// </summary>
         /// <param name="configurations">Sets the configurations for the translation operation
-        /// including source and target storage for documents to be translated. </param>
+        /// including source and target containers for documents to be translated. </param>
         /// <param name="cancellationToken">A <see cref="CancellationToken"/> controlling the request lifetime.</param>
         /// <exception cref="RequestFailedException">Service returned a non-success status code. </exception>
         public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(IEnumerable<TranslationConfiguration> configurations, CancellationToken cancellationToken = default)
@@ -155,49 +155,18 @@ public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(IE
         }
 
         /// <summary>
-        /// Starts a translation operation for documents in an Azure Blob Container.
+        /// Starts a translation operation.
         /// For document length limits, maximum batch size, and supported document formats, see
         /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/document-translation/overview"/>.
         /// </summary>
-        /// <param name="sourceBlobContainerSas">The SAS URL for the source container containing documents to be translated. </param>
-        /// <param name="targetBlobContainerSas">The SAS URL for the target container to which the translated documents will be written. </param>
-        /// <param name="targetLanguageCode">Language code to translate documents to. For supported languages see
-        /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/language-support#translate"/>.</param>
-        /// <param name="glossary">Custom translation glossary to be used in the translation operation. For supported file types see
-        /// <see cref="GetGlossaryFormatsAsync(CancellationToken)"/>.</param>
-        /// <param name="options">Set translation options including source language and custom translation category.</param>
+        /// <param name="configuration">Sets the configurations for the translation operation
+        /// including source and target containers for documents to be translated. </param>
         /// <param name="cancellationToken">A <see cref="CancellationToken"/> controlling the request lifetime.</param>
-        public virtual DocumentTranslationOperation StartTranslation(Uri sourceBlobContainerSas, Uri targetBlobContainerSas, string targetLanguageCode, TranslationGlossary glossary = default, TranslationOperationOptions options = default, CancellationToken cancellationToken = default)
+        /// <exception cref="RequestFailedException">Service returned a non-success status code. </exception>
+        public virtual DocumentTranslationOperation StartTranslation(TranslationConfiguration configuration, CancellationToken cancellationToken = default)
         {
-            var source = new TranslationSource(sourceBlobContainerSas)
-            {
-                LanguageCode = options?.SourceLanguage,
-                Filter = options?.Filter
-            };
-
-            var target = new TranslationTarget(targetBlobContainerSas, targetLanguageCode)
-            {
-                CategoryId = options?.Category
-            };
-
-            if (glossary != null)
-            {
-                target.Glossaries.Add(glossary);
-            }
-
-            var targets = new List<TranslationTarget>
-            {
-               target
-            };
-
-            var request = new BatchSubmissionRequest(new List<TranslationConfiguration>
-                {
-                    new TranslationConfiguration(source, targets)
-                    {
-                        StorageType = options?.StorageType
-                    }
-                }
-            );
+            Argument.AssertNotNull(configuration, nameof(configuration));
+            var request = new BatchSubmissionRequest(new List<TranslationConfiguration> { configuration });
             using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(DocumentTranslationClient)}.{nameof(StartTranslation)}");
             scope.Start();
 
@@ -214,50 +183,18 @@ public virtual DocumentTranslationOperation StartTranslation(Uri sourceBlobConta
         }
 
         /// <summary>
-        /// Starts a translation operation for documents in an Azure Blob Container.
+        /// Starts a translation operation
         /// For document length limits, maximum batch size, and supported document formats, see
         /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/document-translation/overview"/>.
         /// </summary>
-        /// <param name="sourceBlobContainerSas">The SAS URL for the source container containing documents to be translated. </param>
-        /// <param name="targetBlobContainerSas">The SAS URL for the target container to which the translated documents will be written. </param>
-        /// <param name="targetLanguageCode">Language code to translate documents to. For supported languages see
-        /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/language-support#translate"/>.</param>
-        /// <param name="glossary">Custom translation glossary to be used in the translation operation. For supported file types see
-        /// <see cref="GetGlossaryFormatsAsync(CancellationToken)"/>.</param>
-        /// <param name="options">Set translation options including source language and custom translation category.</param>
+        /// <param name="configuration">Sets the configurations for the translation operation
+        /// including source and target containers for documents to be translated. </param>
         /// <param name="cancellationToken">A <see cref="CancellationToken"/> controlling the request lifetime.</param>
-        public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(Uri sourceBlobContainerSas, Uri targetBlobContainerSas, string targetLanguageCode, TranslationGlossary glossary = default, TranslationOperationOptions options = default, CancellationToken cancellationToken = default)
+        /// <exception cref="RequestFailedException">Service returned a non-success status code. </exception>
+        public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(TranslationConfiguration configuration, CancellationToken cancellationToken = default)
         {
-            var source = new TranslationSource(sourceBlobContainerSas)
-            {
-                LanguageCode = options?.SourceLanguage,
-                Filter = options?.Filter
-            };
-
-            var target = new TranslationTarget(targetBlobContainerSas, targetLanguageCode)
-            {
-                CategoryId = options?.Category
-            };
-
-            if (glossary != null)
-            {
-                target.Glossaries.Add(glossary);
-            }
-
-            var targets = new List<TranslationTarget>
-            {
-               target
-            };
-
-            var request = new BatchSubmissionRequest(new List<TranslationConfiguration>
-                {
-                    new TranslationConfiguration(source, targets)
-                    {
-                        StorageType = options?.StorageType
-                    }
-                }
-            );
-
+            Argument.AssertNotNull(configuration, nameof(configuration));
+            var request = new BatchSubmissionRequest(new List<TranslationConfiguration> { configuration });
             using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(DocumentTranslationClient)}.{nameof(StartTranslationAsync)}");
             scope.Start();
 

sdk/documenttranslation/Azure.AI.DocumentTranslation/src/TranslationConfiguration.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using System;
 using Azure.Core;
 
 namespace Azure.AI.DocumentTranslation
@@ -9,5 +10,42 @@ namespace Azure.AI.DocumentTranslation
     [CodeGenModel("BatchRequest")]
     public partial class TranslationConfiguration
     {
+        /// <summary>
+        /// Initializes a new instance of TranslationConfiguration.
+        /// </summary>
+        /// <param name="sourceUri">The SAS URI for the source container containing documents to be translated.</param>
+        /// <param name="targetUri">The SAS URI for the target container to which the translated documents will be written.</param>
+        /// <param name="targetLanguageCode">Language code to translate documents to. For supported languages see
+        /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/language-support#translate"/>.</param>
+        /// <param name="glossary">Custom <see cref="TranslationGlossary"/> to be used in the translation operation. For supported file types see
+        /// <see cref="DocumentTranslationClient.GetGlossaryFormatsAsync(System.Threading.CancellationToken)"/>.</param>
+        public TranslationConfiguration(Uri sourceUri, Uri targetUri, string targetLanguageCode, TranslationGlossary glossary = default)
+        {
+            Source = new TranslationSource(sourceUri);
+            var target = new TranslationTarget(targetUri, targetLanguageCode);
+            if (glossary != null)
+            {
+                target.Glossaries.Add(glossary);
+            }
+            Targets.Add(target);
+        }
+
+        /// <summary>
+        /// Add Translation Target to the configuration.
+        /// </summary>
+        /// <param name="targetUri">The SAS URI for the target container to which the translated documents will be written.</param>
+        /// <param name="languageCode">Language code to translate documents to. For supported languages see
+        /// <a href="https://docs.microsoft.com/azure/cognitive-services/translator/language-support#translate"/>.</param>
+        /// <param name="glossary">Custom <see cref="TranslationGlossary"/> to be used in the translation operation. For supported file types see
+        /// <see cref="DocumentTranslationClient.GetGlossaryFormatsAsync(System.Threading.CancellationToken)"/>.</param>
+        public void AddTarget(Uri targetUri, string languageCode, TranslationGlossary glossary = default)
+        {
+            var target = new TranslationTarget(targetUri, languageCode);
+            if (glossary != null)
+            {
+                target.Glossaries.Add(glossary);
+            }
+            Targets.Add(target);
+        }
     }
 }