Upgrade MSAL to the latest version (Azure#25974)

* update MSAL

Author: christothes

eng/Packages.Data.props

@@ -98,8 +98,8 @@
 
     <!-- Other approved packages -->
     <PackageReference Update="Microsoft.Azure.Amqp" Version="2.5.8" />
-    <PackageReference Update="Microsoft.Identity.Client" Version="4.30.1" />
-    <PackageReference Update="Microsoft.Identity.Client.Extensions.Msal" Version="2.18.4" />
+    <PackageReference Update="Microsoft.Identity.Client" Version="4.39.0" />
+    <PackageReference Update="Microsoft.Identity.Client.Extensions.Msal" Version="2.19.3" />
 
     <!-- TODO: Make sure this package is arch-board approved -->
     <PackageReference Update="System.IdentityModel.Tokens.Jwt" Version="5.4.0" />

sdk/identity/Azure.Identity/tests/ClientCertificateCredentialLiveTests.cs

@@ -22,7 +22,6 @@ public ClientCertificateCredentialLiveTests(bool isAsync) : base(isAsync, useLeg
         public void ClearDiscoveryCache()
         {
             StaticCachesUtilities.ClearStaticMetadataProviderCache();
-            StaticCachesUtilities.ClearAuthorityEndpointResolutionManagerCache();
         }
 
         [TestCase(true)]

sdk/identity/Azure.Identity/tests/ClientSecretCredentialLiveTests.cs

@@ -21,7 +21,6 @@ public ClientSecretCredentialLiveTests(bool isAsync) : base(isAsync, useLegacyTr
         public void ClearDiscoveryCache()
         {
             StaticCachesUtilities.ClearStaticMetadataProviderCache();
-            StaticCachesUtilities.ClearAuthorityEndpointResolutionManagerCache();
         }
 
         [Test]

sdk/identity/Azure.Identity/tests/CredentialTestHelpers.cs

@@ -148,7 +148,6 @@ public static async Task<string> GetRefreshTokenAsync(IdentityTestEnvironment te
             await client.AcquireTokenByUsernamePassword(new[] { testEnvironment.KeyvaultScope }, username, password.ToSecureString()).ExecuteAsync();
 
             StaticCachesUtilities.ClearStaticMetadataProviderCache();
-            StaticCachesUtilities.ClearAuthorityEndpointResolutionManagerCache();
             return retriever.RefreshToken;
         }
 

sdk/identity/Azure.Identity/tests/IdentityRecordedTestBase.cs

@@ -29,6 +29,9 @@ private void InitialzeRecordingSettings()
             // x-ms-PKeyAuth is only added on MAC and Linux so recordings made on windows will fail on these platforms and vice-versa
             // ignoring this header as CI must run on all platforms
             Matcher.LegacyExcludedHeaders.Add("x-ms-PKeyAuth");
+            Matcher.LegacyExcludedHeaders.Add("x-client-current-telemetry");
+            Matcher.LegacyExcludedHeaders.Add("x-client-last-telemetry");
+            Matcher.LegacyExcludedHeaders.Add("x-anchormailbox");
             Sanitizer = new IdentityRecordedTestSanitizer();
         }
     }

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialFederatedTokenLiveTests.cs

@@ -26,7 +26,6 @@ public ManagedIdentityCredentialFederatedTokenLiveTests(bool isAsync) : base(isA
         public void ClearDiscoveryCache()
         {
             StaticCachesUtilities.ClearStaticMetadataProviderCache();
-            StaticCachesUtilities.ClearAuthorityEndpointResolutionManagerCache();
         }
 
         [NonParallelizable]

sdk/identity/Azure.Identity/tests/StaticCachesUtilities.cs

@@ -19,29 +19,6 @@ internal static class StaticCachesUtilities
             MethodCallExpression invokeClear = Expression.Call(callConstructor, clearMethod);
             return Expression.Lambda<Action>(invokeClear).Compile();
         });
-
-        private static readonly Lazy<Action> s_clearAuthorityEndpointResolutionManager = new Lazy<Action>(() =>
-        {
-            var assembly = typeof(PublicClientApplication).Assembly;
-            Type authorityEndpointResolutionManagerType = assembly.GetType("Microsoft.Identity.Client.Instance.AuthorityResolutionManager", true);
-            Type iServiceBundleType = assembly.GetType("Microsoft.Identity.Client.Internal.IServiceBundle", true);
-            Type booleanType = typeof(bool);
-
-            ConstructorInfo[] constructors = authorityEndpointResolutionManagerType.GetConstructors(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
-            foreach (ConstructorInfo constructor in constructors)
-            {
-                var parameters = constructor.GetParameters();
-                if (parameters.Length == 1 && parameters[0].ParameterType == booleanType)
-                {
-                    NewExpression callConstructor = Expression.New(constructor, Expression.Constant(true, booleanType));
-                    return Expression.Lambda<Action>(callConstructor).Compile();
-                }
-            }
-
-            throw new InvalidOperationException("Constructor wasn't found");
-        });
-
         public static void ClearStaticMetadataProviderCache() => s_clearStaticMetadataProvider.Value();
-        public static void ClearAuthorityEndpointResolutionManagerCache() => s_clearAuthorityEndpointResolutionManager.Value();
     }
 }

sdk/identity/Azure.Identity/tests/TokenCacheTests.cs

@@ -424,9 +424,7 @@ public async Task UnsafeOptions()
 
         private static TokenCacheNotificationArgs GetMockArgs(Mock<ITokenCacheSerializer> mockSerializer, bool hasStateChanged)
         {
-            TokenCacheNotificationArgs mockArgs = (TokenCacheNotificationArgs)FormatterServices.GetUninitializedObject(typeof(TokenCacheNotificationArgs));
-            var ctor = typeof(TokenCacheNotificationArgs).GetConstructors(BindingFlags.NonPublic | BindingFlags.Instance);
-            mockArgs = (TokenCacheNotificationArgs)ctor[0].Invoke(new object[] { mockSerializer.Object, "foo", null, hasStateChanged, true, true, null });
+            var mockArgs = new TokenCacheNotificationArgs(mockSerializer.Object, "foo", null, hasStateChanged, true, "key", true, null, default );
             return mockArgs;
         }
 

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs

@@ -93,7 +93,7 @@ public void EnviornmentSpecifiedNonHttpsAuthorityHostFails()
             {
                 Assert.Throws<ArgumentException>(() => new ClientCertificateCredential(tenantId, clientId, certificatePath, new ClientCertificateCredentialOptions()));
                 Assert.Throws<ArgumentException>(() => new ClientSecretCredential(tenantId, clientId, password, new TokenCredentialOptions()));
-                Assert.Throws<ArgumentException>(() => new DefaultAzureCredential(new DefaultAzureCredentialOptions()));
+                Assert.Throws(Is.TypeOf<ArgumentException>().Or.TypeOf<TypeInitializationException>(), () => new DefaultAzureCredential(new DefaultAzureCredentialOptions()));
                 Assert.Throws<ArgumentException>(() => new DeviceCodeCredential(new DeviceCodeCredentialOptions()));
                 Assert.Throws<ArgumentException>(() => new InteractiveBrowserCredential(new InteractiveBrowserCredentialOptions()));
                 Assert.Throws<ArgumentException>(() => new SharedTokenCacheCredential(new SharedTokenCacheCredentialOptions()));

sdk/identity/Azure.Identity/tests/UsernamePasswordCredentialLiveTests.cs

@@ -50,7 +50,6 @@ public UsernamePasswordCredentialLiveTests(bool isAsync) : base(isAsync, useLega
         public void ClearDiscoveryCache()
         {
             StaticCachesUtilities.ClearStaticMetadataProviderCache();
-            StaticCachesUtilities.ClearAuthorityEndpointResolutionManagerCache();
         }
 
         // !!!!!! WARNING !!!!!