Fix build warnings (Azure#20921)

Author: pakrym

sdk/batch/Microsoft.Azure.Batch/tests/IntegrationTests/Microsoft.Azure.Batch.Integration.Tests.csproj

@@ -8,7 +8,7 @@
     <AssemblyTitle>Microsoft Azure Batch Integration Tests</AssemblyTitle>
   </PropertyGroup>
 
-  <PropertyGroup Condition=" '$(TargetFramework)'=='net452' ">
+  <PropertyGroup Condition=" '$(IsTargetingNetFx)'=='true' ">
     <DefineConstants>FullNetFx</DefineConstants>
     <OutputPath>bin\$(Configuration)\</OutputPath>
     <DocumentationFile></DocumentationFile>
@@ -28,11 +28,6 @@
     </Content>
   </ItemGroup>
 
-  <!--<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">
-    <DefineConstants>netcoreapp11</DefineConstants>
-    <OutputPath>bin\$(Configuration)\</OutputPath>
-    <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
-  </PropertyGroup>-->
   <ItemGroup>
 		<PackageReference Include="Azure.Storage.Blobs" />
 		<PackageReference Include="Microsoft.Azure.Management.Batch" />
@@ -58,13 +53,11 @@
     <ProjectReference Include="..\TestCommon\Microsoft.Azure.Batch.Common.csproj" />
     <ProjectReference Include="..\IntegrationTestCommon\Microsoft.Azure.Batch.IntegrationTestCommon.csproj" />
   </ItemGroup>
-  
-  <ItemGroup>
+
+  <ItemGroup Condition=" '$(IsTargetingNetFx)'=='true' ">
     <Reference Include="System.Net" />
     <Reference Include="System.Net.Http" />
-    <Reference Include="WindowsBase" />
-  </ItemGroup>
-  <ItemGroup Condition=" '$(IsTargetingNetFx)'=='true' ">
     <Reference Include="System.Windows.Forms" />
+    <Reference Include="WindowsBase" />
   </ItemGroup>
 </Project>

sdk/batch/Microsoft.Azure.Batch/tests/UnitTests/Microsoft.Azure.Batch.Unit.Tests.csproj

@@ -49,7 +49,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <Reference Include="System.Net" />
     <Reference Include="System.Net.Http" />
   </ItemGroup>
 </Project>

sdk/containerregistry/Azure.Containers.ContainerRegistry/tests/Azure.Containers.ContainerRegistry.Tests.csproj

@@ -17,15 +17,7 @@
     <ProjectReference Include="..\src\Azure.Containers.ContainerRegistry.csproj" />
   </ItemGroup>
 
-  <!-- TODO: revert when Azure.Core ships -->
-  <ItemGroup>
-    <ProjectReference Include="..\..\..\core\Azure.Core\src\Azure.Core.csproj" />
-  </ItemGroup>
-  <!--  end TODO-->
-
-  <ItemGroup>
-    <Reference Include="System.Web">
-      <HintPath>..\..\..\..\..\..\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7\System.Web.dll</HintPath>
-    </Reference>
+  <ItemGroup Condition="'$(IsTargetingNetFx)' == 'true'">
+    <Reference Include="System.Web" />
   </ItemGroup>
 </Project>

sdk/search/Azure.Search.Documents/tests/Azure.Search.Documents.Tests.csproj

@@ -6,7 +6,7 @@
     <NoWarn>$(NoWarn);CS1591</NoWarn>
   </PropertyGroup>
 
-  <ItemGroup>
+  <ItemGroup Condition="'$(IsTargetingNetFx)' == 'true'">
     <Reference Include="System.ComponentModel.DataAnnotations" />
   </ItemGroup>
 

sdk/search/Microsoft.Azure.Search/tests/Microsoft.Azure.Search.Tests.csproj

@@ -15,8 +15,11 @@
     <ExcludeFromTest>false</ExcludeFromTest>
   </PropertyGroup>
 
-  <ItemGroup>
+  <ItemGroup Condition="'$(IsTargetingNetFx)' == 'true'">
     <Reference Include="System.ComponentModel.DataAnnotations" />
+  </ItemGroup>
+
+  <ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.WebUtilities" />
     <ProjectReference Include="..\src\Microsoft.Azure.Search.csproj" />
     <ProjectReference Include="..\..\Microsoft.Azure.Management.Search\tests\Microsoft.Azure.Management.Search.Tests.csproj" />