Add ConfigurationSetting constructor that takes ETag (Azure#23099)

Author: pakrym

sdk/appconfiguration/Azure.Data.AppConfiguration/api/Azure.Data.AppConfiguration.netstandard2.0.cs

@@ -60,6 +60,7 @@ public static partial class ConfigurationModelFactory
     public partial class ConfigurationSetting
     {
         public ConfigurationSetting(string key, string value, string label = null) { }
+        public ConfigurationSetting(string key, string value, string label, Azure.ETag etag) { }
         public string ContentType { get { throw null; } set { } }
         public Azure.ETag ETag { get { throw null; } }
         public bool? IsReadOnly { get { throw null; } }

sdk/appconfiguration/Azure.Data.AppConfiguration/src/ConfigurationSetting.cs

@@ -27,11 +27,23 @@ internal ConfigurationSetting()
         /// <param name="key">The primary identifier of the configuration setting.</param>
         /// <param name="value">The configuration setting's value.</param>
         /// <param name="label">A label used to group this configuration setting with others.</param>
-        public ConfigurationSetting(string key, string value, string label = null)
+        public ConfigurationSetting(string key, string value, string label = null): this(key, value, label, default)
+        {
+        }
+
+        /// <summary>
+        /// Creates a configuration setting and sets the values from the passed in parameter to this setting.
+        /// </summary>
+        /// <param name="key">The primary identifier of the configuration setting.</param>
+        /// <param name="value">The configuration setting's value.</param>
+        /// <param name="label">A label used to group this configuration setting with others.</param>
+        /// <param name="etag">The ETag value for the configuration setting.</param>
+        public ConfigurationSetting(string key, string value, string label, ETag etag)
         {
             Key = key;
             Value = value;
             Label = label;
+            ETag = etag;
         }
 
         /// <summary>

sdk/appconfiguration/Azure.Data.AppConfiguration/tests/ConfigurationLiveTests.cs

@@ -805,6 +805,26 @@ public async Task GetIfChangedSettingModified()
             }
         }
 
+        [RecordedTest]
+        public async Task GetIfChangedSettingNotModified()
+        {
+            ConfigurationClient service = GetClient();
+            ConfigurationSetting testSetting = CreateSetting();
+
+            try
+            {
+                ConfigurationSetting setting = await service.AddConfigurationSettingAsync(testSetting);
+
+                Response<ConfigurationSetting> response = await service.GetConfigurationSettingAsync(new ConfigurationSetting(setting.Key, "", setting.Label, setting.ETag), onlyIfChanged: true).ConfigureAwait(false);
+                Assert.AreEqual(304, response.GetRawResponse().Status);
+                Assert.Catch<Exception>(() => _ = response.Value);
+            }
+            finally
+            {
+                AssertStatus200(await service.DeleteConfigurationSettingAsync(testSetting.Key, testSetting.Label));
+            }
+        }
+
         [RecordedTest]
         public async Task GetIfChangedSettingUnmodified()
         {

sdk/appconfiguration/Azure.Data.AppConfiguration/tests/ConfigurationSettingTests.cs

@@ -190,5 +190,15 @@ public void ConfigurationSettingDictionarySerialization()
             Assert.IsTrue(comparer.Equals(s_testSetting, deserialized[s_testSetting.Key]));
             Assert.IsNull(deserialized["null_key"]);
         }
+
+        [Test]
+        public void ConfigurationSettingEtagConstructor()
+        {
+            var configurationSetting = new ConfigurationSetting("key", "value", "label", new ETag("etag"));
+            Assert.AreEqual("key", configurationSetting.Key);
+            Assert.AreEqual("value", configurationSetting.Value);
+            Assert.AreEqual("label", configurationSetting.Label);
+            Assert.AreEqual("etag", configurationSetting.ETag.ToString());
+        }
     }
 }