STG 81 API view comments (Azure#26451)

seanmcc-msft · web-flow · commit 647924f887db · 2022-01-18T17:17:05.000-06:00
diff --git a/sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs b/sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs
@@ -795,13 +795,13 @@ public enum ShareFileRangeWriteType
     public partial class ShareFileRenameOptions
     {
         public ShareFileRenameOptions() { }
-        public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions DestinationRequestConditions { get { throw null; } set { } }
+        public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions DestinationConditions { get { throw null; } set { } }
         public string FilePermission { get { throw null; } set { } }
         public bool? IgnoreReadOnly { get { throw null; } set { } }
         public System.Collections.Generic.IDictionary<string, string> Metadata { get { throw null; } set { } }
         public bool? ReplaceIfExists { get { throw null; } set { } }
         public Azure.Storage.Files.Shares.Models.FileSmbProperties SmbProperties { get { throw null; } set { } }
-        public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions SourceRequestConditions { get { throw null; } set { } }
+        public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions SourceConditions { get { throw null; } set { } }
     }
     public partial class ShareFileRequestConditions
     {
diff --git a/sdk/storage/Azure.Storage.Files.Shares/src/Models/ShareFileRenameOptions.cs b/sdk/storage/Azure.Storage.Files.Shares/src/Models/ShareFileRenameOptions.cs
@@ -31,12 +31,12 @@ public class ShareFileRenameOptions
         /// <summary>
         /// Source request conditions.  This parameter is only applicable if the source is a file.
         /// </summary>
-        public ShareFileRequestConditions SourceRequestConditions { get; set; }
+        public ShareFileRequestConditions SourceConditions { get; set; }
 
         /// <summary>
         /// Destination request conditions.
         /// </summary>
-        public ShareFileRequestConditions DestinationRequestConditions { get; set; }
+        public ShareFileRequestConditions DestinationConditions { get; set; }
 
         /// <summary>
         /// Optional SMB properties to set on the destination file or directory.
diff --git a/sdk/storage/Azure.Storage.Files.Shares/src/ShareDirectoryClient.cs b/sdk/storage/Azure.Storage.Files.Shares/src/ShareDirectoryClient.cs
@@ -2472,8 +2472,8 @@ private async Task<Response<ShareDirectoryClient>> RenameInternal(
                             renameSource: Uri.AbsoluteUri,
                             replaceIfExists: options?.ReplaceIfExists,
                             ignoreReadOnly: options?.IgnoreReadOnly,
-                            sourceLeaseId: options?.SourceRequestConditions?.LeaseId,
-                            destinationLeaseId: options?.DestinationRequestConditions?.LeaseId,
+                            sourceLeaseId: options?.SourceConditions?.LeaseId,
+                            destinationLeaseId: options?.DestinationConditions?.LeaseId,
                             filePermission: options?.FilePermission,
                             filePermissionKey: options?.SmbProperties?.FilePermissionKey,
                             metadata: options?.Metadata,
@@ -2487,8 +2487,8 @@ private async Task<Response<ShareDirectoryClient>> RenameInternal(
                             renameSource: Uri.AbsoluteUri,
                             replaceIfExists: options?.ReplaceIfExists,
                             ignoreReadOnly: options?.IgnoreReadOnly,
-                            sourceLeaseId: options?.SourceRequestConditions?.LeaseId,
-                            destinationLeaseId: options?.DestinationRequestConditions?.LeaseId,
+                            sourceLeaseId: options?.SourceConditions?.LeaseId,
+                            destinationLeaseId: options?.DestinationConditions?.LeaseId,
                             filePermission: options?.FilePermission,
                             filePermissionKey: options?.SmbProperties?.FilePermissionKey,
                             metadata: options?.Metadata,
diff --git a/sdk/storage/Azure.Storage.Files.Shares/src/ShareFileClient.cs b/sdk/storage/Azure.Storage.Files.Shares/src/ShareFileClient.cs
@@ -5962,8 +5962,8 @@ private async Task<Response<ShareFileClient>> RenameInternal(
                             renameSource: Uri.AbsoluteUri,
                             replaceIfExists: options?.ReplaceIfExists,
                             ignoreReadOnly: options?.IgnoreReadOnly,
-                            sourceLeaseId: options?.SourceRequestConditions?.LeaseId,
-                            destinationLeaseId: options?.DestinationRequestConditions?.LeaseId,
+                            sourceLeaseId: options?.SourceConditions?.LeaseId,
+                            destinationLeaseId: options?.DestinationConditions?.LeaseId,
                             filePermission: options?.FilePermission,
                             filePermissionKey: options?.SmbProperties?.FilePermissionKey,
                             metadata: options?.Metadata,
@@ -5977,8 +5977,8 @@ private async Task<Response<ShareFileClient>> RenameInternal(
                             renameSource: Uri.AbsoluteUri,
                             replaceIfExists: options?.ReplaceIfExists,
                             ignoreReadOnly: options?.IgnoreReadOnly,
-                            sourceLeaseId: options?.SourceRequestConditions?.LeaseId,
-                            destinationLeaseId: options?.DestinationRequestConditions?.LeaseId,
+                            sourceLeaseId: options?.SourceConditions?.LeaseId,
+                            destinationLeaseId: options?.DestinationConditions?.LeaseId,
                             filePermission: options?.FilePermission,
                             filePermissionKey: options?.SmbProperties?.FilePermissionKey,
                             metadata: options?.Metadata,
diff --git a/sdk/storage/Azure.Storage.Files.Shares/tests/DirectoryClientTests.cs b/sdk/storage/Azure.Storage.Files.Shares/tests/DirectoryClientTests.cs
@@ -1415,7 +1415,7 @@ public async Task RenameAsync_DestinationLeaseId(bool includeLeaseId)
             // Act
             if (includeLeaseId)
             {
-                options.DestinationRequestConditions = new ShareFileRequestConditions
+                options.DestinationConditions = new ShareFileRequestConditions
                 {
                     LeaseId = leaseId
                 };
diff --git a/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs b/sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs
@@ -3816,7 +3816,7 @@ public async Task RenameAsync_SourceLeaseId(bool includeLeaseId)
             {
                 ShareFileRenameOptions options = new ShareFileRenameOptions
                 {
-                    SourceRequestConditions = new ShareFileRequestConditions
+                    SourceConditions = new ShareFileRequestConditions
                     {
                         LeaseId = leaseId
                     }
@@ -3862,7 +3862,7 @@ public async Task RenameAsync_DestinationLeaseId(bool includeLeaseId)
             // Act
             if (includeLeaseId)
             {
-                options.DestinationRequestConditions = new ShareFileRequestConditions
+                options.DestinationConditions = new ShareFileRequestConditions
                 {
                     LeaseId = leaseId
                 };

Original file line number	Diff line number	Diff line change
`@@ -795,13 +795,13 @@ public enum ShareFileRangeWriteType`
`795`	`795`	`public partial class ShareFileRenameOptions`
`796`	`796`	`{`
`797`	`797`	`public ShareFileRenameOptions() { }`
`798`		`- public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions DestinationRequestConditions { get { throw null; } set { } }`
	`798`	`+ public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions DestinationConditions { get { throw null; } set { } }`
`799`	`799`	`public string FilePermission { get { throw null; } set { } }`
`800`	`800`	`public bool? IgnoreReadOnly { get { throw null; } set { } }`
`801`	`801`	`public System.Collections.Generic.IDictionary<string, string> Metadata { get { throw null; } set { } }`
`802`	`802`	`public bool? ReplaceIfExists { get { throw null; } set { } }`
`803`	`803`	`public Azure.Storage.Files.Shares.Models.FileSmbProperties SmbProperties { get { throw null; } set { } }`
`804`		`- public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions SourceRequestConditions { get { throw null; } set { } }`
	`804`	`+ public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions SourceConditions { get { throw null; } set { } }`
`805`	`805`	`}`
`806`	`806`	`public partial class ShareFileRequestConditions`
`807`	`807`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1415,7 +1415,7 @@ public async Task RenameAsync_DestinationLeaseId(bool includeLeaseId)`
`1415`	`1415`	`// Act`
`1416`	`1416`	`if (includeLeaseId)`
`1417`	`1417`	`{`
`1418`		`- options.DestinationRequestConditions = new ShareFileRequestConditions`
	`1418`	`+ options.DestinationConditions = new ShareFileRequestConditions`
`1419`	`1419`	`{`
`1420`	`1420`	`LeaseId = leaseId`
`1421`	`1421`	`};`
Original file line number	Diff line number	Diff line change
`@@ -3816,7 +3816,7 @@ public async Task RenameAsync_SourceLeaseId(bool includeLeaseId)`
`3816`	`3816`	`{`
`3817`	`3817`	`ShareFileRenameOptions options = new ShareFileRenameOptions`
`3818`	`3818`	`{`
`3819`		`- SourceRequestConditions = new ShareFileRequestConditions`
	`3819`	`+ SourceConditions = new ShareFileRequestConditions`
`3820`	`3820`	`{`
`3821`	`3821`	`LeaseId = leaseId`
`3822`	`3822`	`}`
`@@ -3862,7 +3862,7 @@ public async Task RenameAsync_DestinationLeaseId(bool includeLeaseId)`
`3862`	`3862`	`// Act`
`3863`	`3863`	`if (includeLeaseId)`
`3864`	`3864`	`{`
`3865`		`- options.DestinationRequestConditions = new ShareFileRequestConditions`
	`3865`	`+ options.DestinationConditions = new ShareFileRequestConditions`
`3866`	`3866`	`{`
`3867`	`3867`	`LeaseId = leaseId`
`3868`	`3868`	`};`