Replace assert imports with chai in AppConfiguration (Azure#19245)

* Replace assert imports with chai

* Fixing types errors

* Fixing tests

* Catch not recognized error

* Rushx format

* Casting for OperationOptions & {keyFilter ?: string}

* Feature flag as ConfigurationSettingParam<string> instead of as any

Author: JonathanCrd

sdk/appconfiguration/app-configuration/rollup.base.config.js

@@ -119,7 +119,6 @@ export function browserConfig(test = false) {
       cjs({
         namedExports: {
           chai: ["assert", "expect", "use"],
-          assert: ["ok", "equal", "strictEqual", "deepEqual", "fail", "throws", "notEqual"],
           events: ["EventEmitter"],
           ...openTelemetryCommonJs()
         }

sdk/appconfiguration/app-configuration/test/internal/helpers.spec.ts

@@ -13,9 +13,10 @@ import {
   formatFieldsForSelect,
   serializeAsConfigurationSettingParam
 } from "../../src/internal/helpers";
-import * as assert from "assert";
+import { assert } from "chai";
 import {
   ConfigurationSetting,
+  ConfigurationSettingParam,
   featureFlagContentType,
   HttpResponseField,
   HttpResponseFields,
@@ -155,7 +156,7 @@ describe("helper methods", () => {
         featureFlag.value = value as any;
         assert.deepEqual(
           serializeAsConfigurationSettingParam(featureFlag),
-          featureFlag,
+          (featureFlag as unknown) as ConfigurationSettingParam<string>,
           "setting was modified"
         );
       });
@@ -170,7 +171,7 @@ describe("helper methods", () => {
         setting.value = value as any;
         assert.deepEqual(
           serializeAsConfigurationSettingParam(setting),
-          setting,
+          setting as any,
           "setting was modified"
         );
       });

sdk/appconfiguration/app-configuration/test/internal/http.spec.ts

@@ -5,7 +5,7 @@
 // Licensed under the MIT License.
 
 import { parseSyncToken, SyncTokens } from "../../src/internal/synctokenpolicy";
-import * as assert from "assert";
+import { assert } from "chai";
 import { AppConfigurationClient } from "../../src";
 import nock from "nock";
 import {

sdk/appconfiguration/app-configuration/test/internal/package.spec.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import * as assert from "assert";
+import { assert } from "chai";
 import { isNode } from "@azure/core-http";
 
 import { packageVersion } from "../../src/appConfigurationClient";

sdk/appconfiguration/app-configuration/test/internal/tracingHelpers.spec.ts

@@ -4,7 +4,7 @@
 import { createSpan, trace } from "../../src/internal/tracingHelpers";
 import { Span, SpanStatus, SpanStatusCode } from "@azure/core-tracing";
 
-import * as assert from "assert";
+import { assert } from "chai";
 import sinon from "sinon";
 import { AppConfigurationClient } from "../../src/appConfigurationClient";
 import { AbortSignalLike, OperationOptions } from "@azure/core-http";
@@ -92,6 +92,9 @@ describe("tracingHelpers", () => {
 
       assert.fail("Exception should have been thrown from `trace` since the inner action threw");
     } catch (err) {
+      if (!(err instanceof Error)) {
+        throw new Error("Error is not recognized");
+      }
       assert.equal(err.message, "Purposefully thrown error");
     }
 
@@ -172,15 +175,19 @@ describe("tracingHelpers", () => {
 
     assert.deepEqual(traceData, {
       operationName: "listConfigurationSettings",
-      options: { ...operationOptions, keyFilter: "ignored" }
+      options: { ...operationOptions, keyFilter: "ignored" } as OperationOptions & {
+        keyFilter?: string;
+      }
     });
 
     const it2 = appConfigurationClient.listRevisions({ keyFilter: "ignored", ...operationOptions });
     await it2.next();
 
     assert.deepEqual(traceData, {
       operationName: "listRevisions",
-      options: { ...operationOptions, keyFilter: "ignored" }
+      options: { ...operationOptions, keyFilter: "ignored" } as OperationOptions & {
+        keyFilter?: string;
+      }
     });
   });
 });

sdk/appconfiguration/app-configuration/test/public/auth.spec.ts

@@ -7,7 +7,7 @@ import {
   getTokenAuthenticationCredential,
   CredsAndEndpoint
 } from "./utils/testHelpers";
-import * as assert from "assert";
+import { assert } from "chai";
 import { Recorder } from "@azure-tools/test-recorder";
 import { Context } from "mocha";
 

sdk/appconfiguration/app-configuration/test/public/etags.spec.ts

@@ -8,7 +8,7 @@ import {
   deleteKeyCompletely,
   assertThrowsRestError
 } from "./utils/testHelpers";
-import * as assert from "assert";
+import { assert } from "chai";
 import { Recorder } from "@azure-tools/test-recorder";
 import { Context } from "mocha";
 

sdk/appconfiguration/app-configuration/test/public/index.readonlytests.spec.ts

@@ -9,7 +9,7 @@ import {
   startRecorder
 } from "./utils/testHelpers";
 import { AppConfigurationClient } from "../../src";
-import * as assert from "assert";
+import { assert } from "chai";
 import { Recorder } from "@azure-tools/test-recorder";
 import { Context } from "mocha";
 

sdk/appconfiguration/app-configuration/test/public/throwOrNotThrow.spec.ts

@@ -8,7 +8,7 @@ import {
   assertThrowsRestError,
   startRecorder
 } from "./utils/testHelpers";
-import * as assert from "assert";
+import { assert } from "chai";
 import { Recorder } from "@azure-tools/test-recorder";
 import { Context } from "mocha";
 

sdk/appconfiguration/app-configuration/test/public/utils/testHelpers.ts

@@ -15,9 +15,10 @@ import {
   record,
   Recorder
 } from "@azure-tools/test-recorder";
-import * as assert from "assert";
+import { assert } from "chai";
 
 import { DefaultAzureCredential, TokenCredential } from "@azure/identity";
+import { RestError } from "@azure/core-http";
 
 let connectionStringNotPresentWarning = false;
 let tokenCredentialsNotPresentWarning = false;
@@ -144,7 +145,7 @@ export function assertEqualSettings(
   actual = actual.map((setting) => {
     return {
       key: setting.key,
-      label: setting.label,
+      label: setting.label || undefined,
       value: setting.value,
       isReadOnly: setting.isReadOnly
     };
@@ -162,6 +163,9 @@ export async function assertThrowsRestError(
     await testFunction();
     assert.fail(`${message}: No error thrown`);
   } catch (err) {
+    if (!(err instanceof RestError)) {
+      throw new Error("Error is not recognized");
+    }
     if (err.name === "RestError") {
       assert.equal(expectedStatusCode, err.statusCode, message);
       return err;
@@ -181,6 +185,9 @@ export async function assertThrowsAbortError(
     await testFunction();
     assert.fail(`${message}: No error thrown`);
   } catch (e) {
+    if (!(e instanceof Error)) {
+      throw new Error("Error is not recognized");
+    }
     if (isPlaybackMode() && (e.name === "FetchError" || e.name === "AbortError")) {
       return e;
     } else {