OpenTelemetry Exporter arch board feedback (Azure#13810)

* OpenTelemetry Exporter arch board feedback

* Lint

* Api extractor update

Author: hectorhdzg

sdk/monitor/monitor-opentelemetry-exporter/review/monitor-opentelemetry-exporter.api.md

@@ -11,14 +11,14 @@ import { SpanExporter } from '@opentelemetry/tracing';
 // @public (undocumented)
 export interface AzureExporterConfig {
     // (undocumented)
-    connectionString?: string;
+    apiVersion?: ServiceApiVersion;
     // (undocumented)
-    serviceApiVersion?: ServiceApiVersion;
+    connectionString?: string;
 }
 
 // @public (undocumented)
 export class AzureMonitorTraceExporter implements SpanExporter {
-    constructor(options?: Partial<AzureExporterConfig>);
+    constructor(options?: AzureExporterConfig);
     // (undocumented)
     export(spans: ReadableSpan[], resultCallback: (result: ExportResult) => void): Promise<void>;
     // (undocumented)

sdk/monitor/monitor-opentelemetry-exporter/src/config.ts

@@ -15,7 +15,7 @@ export interface AzureExporterConfig {
   // Setup String
   connectionString?: string;
   // Azure service API version
-  serviceApiVersion?: ServiceApiVersion;
+  apiVersion?: ServiceApiVersion;
 }
 
 export interface AzureExporterInternalConfig {
@@ -32,13 +32,13 @@ export interface AzureExporterInternalConfig {
 
   endpointUrl: string;
 
-  serviceApiVersion: ServiceApiVersion;
+  apiVersion: ServiceApiVersion;
 }
 
 export const DEFAULT_EXPORTER_CONFIG: AzureExporterInternalConfig = {
   instrumentationKey: "",
   endpointUrl: DEFAULT_BREEZE_ENDPOINT,
   batchSendRetryIntervalMs: DEFAULT_BATCH_SEND_RETRY_INTERVAL_MS,
   maxConsecutiveFailuresBeforeWarning: DEFAULT_MAX_CONSECUTIVE_FAILURES_BEFORE_WARNING,
-  serviceApiVersion: DEFAULT_BREEZE_API_VERSION
+  apiVersion: DEFAULT_BREEZE_API_VERSION
 };

sdk/monitor/monitor-opentelemetry-exporter/src/export/trace.ts

@@ -29,13 +29,13 @@ export class AzureMonitorTraceExporter implements SpanExporter {
 
   private readonly _options: AzureExporterInternalConfig;
 
-  constructor(options: Partial<AzureExporterConfig> = {}) {
+  constructor(options: AzureExporterConfig = {}) {
     const connectionString = options.connectionString || process.env[ENV_CONNECTION_STRING];
     this._logger = new ConsoleLogger(LogLevel.ERROR);
     this._options = {
       ...DEFAULT_EXPORTER_CONFIG
     };
-    this._options.serviceApiVersion = options.serviceApiVersion ?? this._options.serviceApiVersion;
+    this._options.apiVersion = options.apiVersion ?? this._options.apiVersion;
 
     if (connectionString) {
       const parsedConnectionString = ConnectionStringParser.parse(connectionString, this._logger);

sdk/monitor/monitor-opentelemetry-exporter/src/platform/nodejs/httpSender.ts

@@ -17,7 +17,7 @@ export class HttpSender implements Sender {
   private readonly _appInsightsClient: ApplicationInsightsClient;
   private _appInsightsClientOptions: ApplicationInsightsClientOptionalParams;
 
-  constructor(private _exporterOptions: Partial<AzureExporterInternalConfig>) {
+  constructor(private _exporterOptions: AzureExporterInternalConfig) {
     this._logger = this._exporterOptions.logger || new ConsoleLogger(LogLevel.ERROR);
     // Build endpoint using provided configuration or default values
     this._appInsightsClientOptions = {