Skip to content

Commit 0c7b18d

Browse files
KarishmaGhiyaKarishmaGhiya
authored
Update functions modified to remove Get calls (Azure#13485)
1 parent 3c5cc69 commit 0c7b18d

File tree

9 files changed

+32
-34
lines changed

9 files changed

+32
-34
lines changed

‎sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1003,10 +1003,10 @@ export class MetricsAdvisorAdministrationClient {
10031003
listDetectionConfigs(metricId: string, options?: OperationOptions): PagedAsyncIterableIterator<AnomalyDetectionConfiguration, DetectionConfigurationsPageResponse, undefined>;
10041004
listHooks(options?: ListHooksOptions): PagedAsyncIterableIterator<NotificationHookUnion, HooksPageResponse>;
10051005
refreshDataFeedIngestion(dataFeedId: string, startTime: Date | string, endTime: Date | string, options?: OperationOptions): Promise<RestResponse>;
1006-
updateAlertConfig(id: string, patch: Partial<Omit<AnomalyAlertConfiguration, "id">>, options?: OperationOptions): Promise<GetAnomalyAlertConfigurationResponse>;
1007-
updateDataFeed(dataFeedId: string, patch: DataFeedPatch, options?: OperationOptions): Promise<GetDataFeedResponse>;
1008-
updateDetectionConfig(id: string, patch: Partial<Omit<AnomalyDetectionConfiguration, "id" | "metricId">>, options?: OperationOptions): Promise<GetAnomalyDetectionConfigurationResponse>;
1009-
updateHook(id: string, patch: EmailNotificationHookPatch | WebNotificationHookPatch, options?: OperationOptions): Promise<GetHookResponse>;
1006+
updateAlertConfig(id: string, patch: Partial<Omit<AnomalyAlertConfiguration, "id">>, options?: OperationOptions): Promise<RestResponse>;
1007+
updateDataFeed(dataFeedId: string, patch: DataFeedPatch, options?: OperationOptions): Promise<RestResponse>;
1008+
updateDetectionConfig(id: string, patch: Partial<Omit<AnomalyDetectionConfiguration, "id" | "metricId">>, options?: OperationOptions): Promise<RestResponse>;
1009+
updateHook(id: string, patch: EmailNotificationHookPatch | WebNotificationHookPatch, options?: OperationOptions): Promise<RestResponse>;
10101010
}
10111011

10121012
// @public

‎sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/detectionConfig.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ async function main() {
3737

3838
const created = await createDetectionConfig(adminClient, metricId);
3939

40-
const updated = await updateDetectionConfig(adminClient, created.id);
40+
await updateDetectionConfig(adminClient, created.id);
4141

4242
await listDetectionConfig(adminClient, metricId);
4343

44-
await deleteDetectionConfig(adminClient, updated.id);
44+
await deleteDetectionConfig(adminClient, created.id);
4545
}
4646

4747
async function getDetectionConfig(adminClient, detectionConfigId) {

‎sdk/metricsadvisor/ai-metrics-advisor/samples/javascript/hooks.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ async function main() {
1717
await getHook(adminClient, existingHookId);
1818

1919
const createdEmailHook = await createEmailHook(adminClient);
20-
const updatedEmailHook = await updateEmailHook(adminClient, createdEmailHook.id);
20+
await updateEmailHook(adminClient, createdEmailHook.id);
2121

2222
const createdWebHook = await createWebHook(adminClient);
2323

2424
await listHooks(adminClient);
2525

26-
await deleteHook(adminClient, updatedEmailHook.id);
26+
await deleteHook(adminClient, createdEmailHook.id);
2727
await deleteHook(adminClient, createdWebHook.id);
2828
}
2929

‎sdk/metricsadvisor/ai-metrics-advisor/samples/typescript/src/detectionConfig.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ export async function main() {
4343

4444
const created = await createDetectionConfig(adminClient, metricId);
4545

46-
const updated = await updateDetectionConfig(adminClient, created.id!);
46+
await updateDetectionConfig(adminClient, created.id!);
4747

4848
await listDetectionConfig(adminClient, metricId);
4949

50-
await deleteDetectionConfig(adminClient, updated.id!);
50+
await deleteDetectionConfig(adminClient, created.id!);
5151
}
5252

5353
async function getDetectionConfig(

‎sdk/metricsadvisor/ai-metrics-advisor/samples/typescript/src/hooks.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ export async function main() {
2121
await getHook(adminClient, existingHookId);
2222

2323
const createdEmailHook = await createEmailHook(adminClient);
24-
const updatedEmailHook = await updateEmailHook(adminClient, createdEmailHook.id!);
24+
await updateEmailHook(adminClient, createdEmailHook.id!);
2525

2626
const createdWebHook = await createWebHook(adminClient);
2727

2828
await listHooks(adminClient);
2929

30-
await deleteHook(adminClient, updatedEmailHook.id!);
30+
await deleteHook(adminClient, createdEmailHook.id!);
3131
await deleteHook(adminClient, createdWebHook.id!);
3232
}
3333

‎sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts‎

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ export class MetricsAdvisorAdministrationClient {
469469
dataFeedId: string,
470470
patch: DataFeedPatch,
471471
options: OperationOptions = {}
472-
): Promise<GetDataFeedResponse> {
472+
): Promise<RestResponse> {
473473
const { span, updatedOptions: finalOptions } = createSpan(
474474
"MetricsAdvisorAdministrationClient-updateDataFeed",
475475
options
@@ -509,8 +509,7 @@ export class MetricsAdvisorAdministrationClient {
509509
status: patch.status,
510510
actionLinkTemplate: patch.actionLinkTemplate
511511
};
512-
await this.client.updateDataFeed(dataFeedId, patchBody, requestOptions);
513-
return this.getDataFeed(dataFeedId);
512+
return await this.client.updateDataFeed(dataFeedId, patchBody, requestOptions);
514513
} catch (e) {
515514
span.setStatus({
516515
code: CanonicalCode.UNKNOWN,
@@ -629,7 +628,7 @@ export class MetricsAdvisorAdministrationClient {
629628
id: string,
630629
patch: Partial<Omit<AnomalyDetectionConfiguration, "id" | "metricId">>,
631630
options: OperationOptions = {}
632-
): Promise<GetAnomalyDetectionConfigurationResponse> {
631+
): Promise<RestResponse> {
633632
const { span, updatedOptions: finalOptions } = createSpan(
634633
"MetricsAdvisorAdministrationClient-updateDetectionConfig",
635634
options
@@ -638,8 +637,7 @@ export class MetricsAdvisorAdministrationClient {
638637
try {
639638
const requestOptions = operationOptionsToRequestOptionsBase(finalOptions);
640639
const transformed = toServiceAnomalyDetectionConfigurationPatch(patch);
641-
await this.client.updateAnomalyDetectionConfiguration(id, transformed, requestOptions);
642-
return this.getDetectionConfig(id);
640+
return await this.client.updateAnomalyDetectionConfiguration(id, transformed, requestOptions);
643641
} catch (e) {
644642
span.setStatus({
645643
code: CanonicalCode.UNKNOWN,
@@ -726,7 +724,7 @@ export class MetricsAdvisorAdministrationClient {
726724
id: string,
727725
patch: Partial<Omit<AnomalyAlertConfiguration, "id">>,
728726
options: OperationOptions = {}
729-
): Promise<GetAnomalyAlertConfigurationResponse> {
727+
): Promise<RestResponse> {
730728
const { span, updatedOptions: finalOptions } = createSpan(
731729
"MetricsAdvisorAdministrationClient-updateAlertConfig",
732730
options
@@ -735,8 +733,7 @@ export class MetricsAdvisorAdministrationClient {
735733
try {
736734
const requestOptions = operationOptionsToRequestOptionsBase(finalOptions);
737735
const transformed = toServiceAlertConfigurationPatch(patch);
738-
await this.client.updateAnomalyAlertingConfiguration(id, transformed, requestOptions);
739-
return this.getAlertConfig(id);
736+
return await this.client.updateAnomalyAlertingConfiguration(id, transformed, requestOptions);
740737
} catch (e) {
741738
span.setStatus({
742739
code: CanonicalCode.UNKNOWN,
@@ -1150,15 +1147,14 @@ export class MetricsAdvisorAdministrationClient {
11501147
id: string,
11511148
patch: EmailNotificationHookPatch | WebNotificationHookPatch,
11521149
options: OperationOptions = {}
1153-
): Promise<GetHookResponse> {
1150+
): Promise<RestResponse> {
11541151
const { span, updatedOptions: finalOptions } = createSpan(
11551152
"MetricsAdvisorAdministrationClient-updateHook",
11561153
options
11571154
);
11581155
try {
11591156
const requestOptions = operationOptionsToRequestOptionsBase(finalOptions);
1160-
await this.client.updateHook(id, patch, requestOptions);
1161-
return this.getHook(id);
1157+
return await this.client.updateHook(id, patch, requestOptions);
11621158
} catch (e) {
11631159
span.setStatus({
11641160
code: CanonicalCode.UNKNOWN,

‎sdk/metricsadvisor/ai-metrics-advisor/test/public/adminclient.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@ matrix([[true, false]] as const, async (useAad) => {
201201
]
202202
};
203203

204-
const actual = await client.updateDetectionConfig(createdDetectionConfigId, expected);
205-
204+
await client.updateDetectionConfig(createdDetectionConfigId, expected);
205+
const actual = await client.getDetectionConfig(createdDetectionConfigId);
206206
assert.ok(actual.id, "Expecting valid detection config");
207207
createdDetectionConfigId = actual.id!;
208208

@@ -320,8 +320,8 @@ matrix([[true, false]] as const, async (useAad) => {
320320
metricAlertConfigurations: [metricAlertConfig, metricAlertConfig]
321321
};
322322

323-
const actual = await client.updateAlertConfig(createdAlertConfigId, patch);
324-
323+
await client.updateAlertConfig(createdAlertConfigId, patch);
324+
const actual = await client.getAlertConfig(createdAlertConfigId);
325325
assert.ok(actual.id, "Expecting valid alerting config");
326326
assert.equal(actual.name, "new alert config name");
327327
assert.equal(actual.description, "new alert config description");

‎sdk/metricsadvisor/ai-metrics-advisor/test/public/datafeed.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,8 @@ matrix([[true, false]] as const, async (useAad) => {
313313
viewerEmails: ["[email protected]"],
314314
actionLinkTemplate: "Updated Azure Blob action link template"
315315
};
316-
const updated = await client.updateDataFeed(createdAzureBlobDataFeedId, patch);
317-
316+
await client.updateDataFeed(createdAzureBlobDataFeedId, patch);
317+
const updated = await client.getDataFeed(createdAzureBlobDataFeedId);
318318
assert.ok(updated.id, "Expecting valid data feed");
319319
assert.equal(updated.source.dataSourceType, "AzureBlob");
320320
assert.deepStrictEqual(updated.source.dataSourceParameter, expectedSourceParameter);
@@ -746,8 +746,8 @@ matrix([[true, false]] as const, async (useAad) => {
746746
}
747747
};
748748

749-
const updated = await client.updateDataFeed(createdPostGreSqlId, patch);
750-
749+
await client.updateDataFeed(createdPostGreSqlId, patch);
750+
const updated = await client.getDataFeed(createdPostGreSqlId);
751751
assert.ok(updated.id, "Expecting valid data feed");
752752
assert.equal(updated.source.dataSourceType, "MongoDB");
753753
assert.deepStrictEqual(

‎sdk/metricsadvisor/ai-metrics-advisor/test/public/hookTests.spec.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ matrix([[true, false]] as const, async (useAad) => {
7878
toList: ["[email protected]", "[email protected]"]
7979
}
8080
};
81-
const updated = await client.updateHook(createdEmailHookId, emailPatch);
81+
await client.updateHook(createdEmailHookId, emailPatch);
82+
const updated = await client.getHook(createdEmailHookId);
8283
assert.equal(updated.hookType, emailPatch.hookType);
8384
const emailHook = updated as EmailNotificationHook;
8485
assert.deepEqual(emailHook.hookParameter.toList, [
@@ -96,7 +97,8 @@ matrix([[true, false]] as const, async (useAad) => {
9697
password: "pass123"
9798
}
9899
};
99-
const updated = await client.updateHook(createdWebHookId, webPatch);
100+
await client.updateHook(createdWebHookId, webPatch);
101+
const updated = await client.getHook(createdWebHookId);
100102
assert.equal(updated.hookType, webPatch.hookType);
101103
const webHook = updated as WebNotificationHook;
102104
assert.equal(webHook.hookParameter.username, "user1");

0 commit comments

Comments
 (0)