mgmt, support validateMoveResources (Azure#24465)

Author: weidongxu-microsoft

sdk/resourcemanager/azure-resourcemanager-resources/CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### Features Added
 
+- Added support for `validateMoveResources` in `GenericResources`.
+
 ### Breaking Changes
 
 ### Bugs Fixed

sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/implementation/GenericResourcesImpl.java

@@ -185,6 +185,21 @@ public GenericResource get(
         return null;
     }
 
+    @Override
+    public void validateMoveResources(String sourceResourceGroupName, ResourceGroup targetResourceGroup,
+                                      List<String> resourceIds) {
+        validateMoveResourcesAsync(sourceResourceGroupName, targetResourceGroup, resourceIds).block();
+    }
+
+    @Override
+    public Mono<Void> validateMoveResourcesAsync(String sourceResourceGroupName, ResourceGroup targetResourceGroup,
+                                                 List<String> resourceIds) {
+        ResourcesMoveInfo moveInfo = new ResourcesMoveInfo();
+        moveInfo.withTargetResourceGroup(targetResourceGroup.id());
+        moveInfo.withResources(resourceIds);
+        return this.inner().validateMoveResourcesAsync(sourceResourceGroupName, moveInfo);
+    }
+
     @Override
     public GenericResource get(
             String resourceGroupName,
@@ -222,16 +237,16 @@ public GenericResource get(
 
     @Override
     public void moveResources(String sourceResourceGroupName,
-            ResourceGroup targetResourceGroup, List<String> resources) {
-        this.moveResourcesAsync(sourceResourceGroupName, targetResourceGroup, resources).block();
+            ResourceGroup targetResourceGroup, List<String> resourceIds) {
+        this.moveResourcesAsync(sourceResourceGroupName, targetResourceGroup, resourceIds).block();
     }
 
     @Override
     public Mono<Void> moveResourcesAsync(String sourceResourceGroupName,
-            ResourceGroup targetResourceGroup, List<String> resources) {
+            ResourceGroup targetResourceGroup, List<String> resourceIds) {
         ResourcesMoveInfo moveInfo = new ResourcesMoveInfo();
         moveInfo.withTargetResourceGroup(targetResourceGroup.id());
-        moveInfo.withResources(resources);
+        moveInfo.withResources(resourceIds);
         return this.inner().moveResourcesAsync(sourceResourceGroupName, moveInfo);
     }
 

sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/models/GenericResources.java

@@ -175,25 +175,48 @@ GenericResource get(
             String resourceType,
             String resourceName);
 
+    /**
+     * Validates move resources from one resource group to another.
+     * If validation fails, {@link com.azure.core.management.exception.ManagementException} is thrown.
+     *
+     * @param sourceResourceGroupName Source resource group name
+     * @param targetResourceGroup target resource group, can be in a different subscription
+     * @param resourceIds the list of IDs of the resources to move
+     */
+    void validateMoveResources(String sourceResourceGroupName, ResourceGroup targetResourceGroup,
+                               List<String> resourceIds);
+
+    /**
+     * Validates move resources from one resource group to another asynchronously.
+     * If validation fails, {@link com.azure.core.management.exception.ManagementException} is thrown.
+     *
+     * @param sourceResourceGroupName Source resource group name
+     * @param targetResourceGroup target resource group, can be in a different subscription
+     * @param resourceIds the list of IDs of the resources to move
+     * @return a representation of the deferred computation of this call
+     */
+    Mono<Void> validateMoveResourcesAsync(String sourceResourceGroupName, ResourceGroup targetResourceGroup,
+                                          List<String> resourceIds);
+
     /**
      * Move resources from one resource group to another.
      *
      * @param sourceResourceGroupName Source resource group name
      * @param targetResourceGroup target resource group, can be in a different subscription
-     * @param resources the list of IDs of the resources to move
+     * @param resourceIds the list of IDs of the resources to move
      */
-    void moveResources(String sourceResourceGroupName, ResourceGroup targetResourceGroup, List<String> resources);
+    void moveResources(String sourceResourceGroupName, ResourceGroup targetResourceGroup, List<String> resourceIds);
 
     /**
      * Move resources from one resource group to another asynchronously.
      *
      * @param sourceResourceGroupName Source resource group name
      * @param targetResourceGroup target resource group, can be in a different subscription
-     * @param resources the list of IDs of the resources to move
+     * @param resourceIds the list of IDs of the resources to move
      * @return a representation of the deferred computation of this call
      */
-    Mono<Void> moveResourcesAsync(String sourceResourceGroupName,
-                                  ResourceGroup targetResourceGroup, List<String> resources);
+    Mono<Void> moveResourcesAsync(String sourceResourceGroupName, ResourceGroup targetResourceGroup,
+                                  List<String> resourceIds);
 
     /**
      * Delete resource and all of its child resources.

sdk/resourcemanager/azure-resourcemanager-resources/src/test/java/com/azure/resourcemanager/resources/GenericResourcesTests.java

@@ -5,6 +5,7 @@
 
 import com.azure.core.http.HttpPipeline;
 import com.azure.core.http.rest.PagedIterable;
+import com.azure.core.management.exception.ManagementException;
 import com.azure.core.util.Context;
 import com.azure.core.util.polling.LongRunningOperationStatus;
 import com.azure.core.util.polling.PollResponse;
@@ -17,6 +18,7 @@
 import com.azure.resourcemanager.resources.models.GenericResource;
 import com.azure.resourcemanager.resources.models.GenericResources;
 import com.azure.resourcemanager.resources.models.Identity;
+import com.azure.resourcemanager.resources.models.ResourceGroup;
 import com.azure.resourcemanager.resources.models.ResourceGroups;
 import com.azure.resourcemanager.resources.models.ResourceIdentityType;
 import com.azure.resourcemanager.resources.models.Sku;
@@ -26,6 +28,9 @@
 
 import java.time.Duration;
 import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
 import java.util.Optional;
 
 public class GenericResourcesTests extends ResourceManagementTest {
@@ -100,6 +105,55 @@ public void canCreateUpdateMoveResource() throws Exception {
         Assertions.assertFalse(genericResources.checkExistenceById(resource.id()));
     }
 
+    @Test
+    public void canValidateMoveResources() throws Exception {
+        final String resourceName = "rs" + testId;
+        final Map<String, Object> properties = new HashMap<>();
+        properties.put("publicIPAllocationMethod", "Dynamic");
+
+        GenericResource resource = genericResources.define(resourceName)
+            .withRegion(Region.US_EAST2)
+            .withExistingResourceGroup(rgName)
+            .withResourceType("publicIPAddresses")
+            .withProviderNamespace("Microsoft.Network")
+            .withoutPlan()
+            .withProperties(properties)
+            .create();
+
+        ResourceGroup targetResourceGroup = resourceGroups.getByName(newRgName);
+        // validate pass as public IP can be moved
+        genericResources.validateMoveResources(rgName, targetResourceGroup, Collections.singletonList(resource.id()));
+
+        // create resource in target group with same name
+        GenericResource resource2 = genericResources.define(resourceName)
+            .withRegion(Region.US_EAST2)
+            .withExistingResourceGroup(newRgName)
+            .withResourceType("publicIPAddresses")
+            .withProviderNamespace("Microsoft.Network")
+            .withoutPlan()
+            .withProperties(properties)
+            .create();
+
+        // validate fail as name conflict
+        Assertions.assertThrows(ManagementException.class, () -> {
+            genericResources.validateMoveResources(rgName, targetResourceGroup, Collections.singletonList(resource.id()));
+        });
+
+        final String resourceName3 = "rs2" + testId;
+        GenericResource resource3 = genericResources.define(resourceName3)
+            .withRegion(Region.US_EAST2)
+            .withExistingResourceGroup(rgName)
+            .withResourceType("userAssignedIdentities")
+            .withProviderNamespace("Microsoft.ManagedIdentity")
+            .withoutPlan()
+            .create();
+
+        // validate fail as managed identity does not support move
+        Assertions.assertThrows(ManagementException.class, () -> {
+            genericResources.validateMoveResources(rgName, targetResourceGroup, Collections.singletonList(resource3.id()));
+        });
+    }
+
     @Test
     public void canCreateDeleteResourceSyncPoll() throws Exception {
         final long defaultDelayInMillis = 10 * 1000;