Configure Azure Core Libraries to Fail Build on Deprecated (Azure#18913)

Updated compiler configuration in Core libraries to fail build on deprecated API usage

Author: alzimmermsft

sdk/core/azure-core-amqp-experimental/pom.xml

@@ -86,4 +86,19 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-compiler-plugin;external_dependency} -->
+        <configuration>
+          <compilerArgs>
+            <arg>-Xlint:deprecation</arg>
+          </compilerArgs>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
 </project>

sdk/core/azure-core-amqp/pom.xml

@@ -133,6 +133,17 @@
           </systemPropertyVariables>
         </configuration>
       </plugin>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-compiler-plugin;external_dependency} -->
+        <configuration>
+          <compilerArgs>
+            <arg>-Xlint:deprecation</arg>
+          </compilerArgs>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 

sdk/core/azure-core-amqp/src/test/java/com/azure/core/amqp/implementation/handler/LinkHandlerTest.java

@@ -31,7 +31,7 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.verifyZeroInteractions;
+import static org.mockito.Mockito.verifyNoInteractions;
 import static org.mockito.Mockito.when;
 
 class LinkHandlerTest {
@@ -110,7 +110,7 @@ void onLinkLocalCloseDoesNotClose() {
         handler.onLinkLocalClose(event);
 
         // Assert
-        verifyZeroInteractions(session);
+        verifyNoInteractions(session);
     }
 
     /**

sdk/core/azure-core-amqp/src/test/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandlerTest.java

@@ -24,7 +24,7 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.verifyZeroInteractions;
+import static org.mockito.Mockito.verifyNoInteractions;
 import static org.mockito.Mockito.when;
 
 public class WebSocketsProxyConnectionHandlerTest {
@@ -130,7 +130,7 @@ public void proxyConfigurationSelected() {
         Assertions.assertEquals(address.getHostName(), handler.getHostname());
         Assertions.assertEquals(address.getPort(), handler.getProtocolPort());
 
-        verifyZeroInteractions(proxySelector);
+        verifyNoInteractions(proxySelector);
     }
 
     @Test

sdk/core/azure-core-experimental/pom.xml

@@ -87,6 +87,21 @@
     </dependency>
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-compiler-plugin;external_dependency} -->
+        <configuration>
+          <compilerArgs>
+            <arg>-Xlint:deprecation</arg>
+          </compilerArgs>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
   <profiles>
     <profile>
       <id>java-lts</id>

sdk/core/azure-core-http-jdk-httpclient/pom.xml

@@ -126,6 +126,21 @@
     </dependency>
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-compiler-plugin;external_dependency} -->
+        <configuration>
+          <compilerArgs>
+            <arg>-Xlint:deprecation</arg>
+          </compilerArgs>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
   <profiles>
     <!-- Library cannot build for Java 10 and below -->
     <profile>

sdk/core/azure-core-http-netty/pom.xml

@@ -198,6 +198,17 @@
           </rules>
         </configuration>
       </plugin>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-compiler-plugin;external_dependency} -->
+        <configuration>
+          <compilerArgs>
+            <arg>-Xlint:deprecation</arg>
+          </compilerArgs>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 

sdk/core/azure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilder.java

@@ -81,6 +81,7 @@ public NettyAsyncHttpClientBuilder(HttpClient nettyHttpClient) {
      * @return A new Netty-backed {@link com.azure.core.http.HttpClient} instance.
      * @throws IllegalStateException If the builder is configured to use an unknown proxy type.
      */
+    @SuppressWarnings("deprecation")
     public com.azure.core.http.HttpClient build() {
         HttpClient nettyHttpClient;
         if (this.baseHttpClient != null) {

sdk/core/azure-core-http-netty/src/samples/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilderJavaDocCodeSnippets.java

@@ -9,7 +9,7 @@
 import com.azure.core.http.ProxyOptions;
 import io.netty.channel.nio.NioEventLoopGroup;
 import io.netty.handler.logging.LogLevel;
-import io.netty.handler.logging.LoggingHandler;
+import reactor.netty.tcp.TcpClient;
 
 import java.net.InetSocketAddress;
 import java.nio.ByteBuffer;
@@ -62,7 +62,7 @@ public void fromExistingReactorNettyClient() {
         // BEGIN: com.azure.core.http.netty.from-existing-http-client
         // Creates a reactor-netty client with netty logging enabled.
         reactor.netty.http.client.HttpClient baseHttpClient = reactor.netty.http.client.HttpClient.create()
-            .tcpConfiguration(tcp -> tcp.bootstrap(b -> b.handler(new LoggingHandler(LogLevel.INFO))));
+            .tcpConfiguration(tcp -> tcp.wiretap(TcpClient.class.getName(), LogLevel.INFO));
         // Create an HttpClient based on above reactor-netty client and configure EventLoop count.
         HttpClient client = new NettyAsyncHttpClientBuilder(baseHttpClient)
             .eventLoopGroup(new NioEventLoopGroup(5))

sdk/core/azure-core-http-netty/src/test/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilderTests.java

@@ -342,6 +342,7 @@ private static Stream<Arguments> buildWithConfigurationProxySupplier() {
         return arguments.stream();
     }
 
+    @SuppressWarnings("deprecation")
     private static HttpClient nettyHttpClientWithProxyValidation(boolean shouldHaveProxy, ProxyOptions.Type proxyType,
         boolean isAuthenticated) {
         TestProxyValidator validator = new TestProxyValidator(shouldHaveProxy, proxyType, isAuthenticated);
@@ -416,7 +417,7 @@ public void connect(ChannelHandlerContext ctx, SocketAddress remoteAddress, Sock
      */
     @Test
     public void buildWiretappedClient() {
-        HttpClient validatorClient = HttpClient.create().doAfterResponse((response, connection) ->
+        HttpClient validatorClient = HttpClient.create().doAfterResponseSuccess((response, connection) ->
             assertNotNull(connection.channel().pipeline().get(LoggingHandler.class)));
 
         NettyAsyncHttpClient nettyClient = (NettyAsyncHttpClient) new NettyAsyncHttpClientBuilder(validatorClient)
@@ -449,7 +450,7 @@ public void buildPortClient() {
     @Test
     public void buildEventLoopClient() {
         String expectedThreadName = "testEventLoop";
-        HttpClient validatorClient = HttpClient.create().doAfterResponse((response, connection) -> {
+        HttpClient validatorClient = HttpClient.create().doAfterResponseSuccess((response, connection) -> {
             // Validate that the EventLoop being used is a NioEventLoop.
             NioEventLoop eventLoop = (NioEventLoop) connection.channel().eventLoop();
             assertNotNull(eventLoop);