Skip to content

Commit 5c24c9a

Browse files
authored
Prelim SDK BOM for this month. (Azure#26587)
BOM release for this month with additional changes to the generator to strip out external dependencies.
1 parent 30f53ee commit 5c24c9a

File tree

5 files changed

+72
-164
lines changed

5 files changed

+72
-164
lines changed

eng/bomgenerator/generateAzureSDKBOM.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ if(! (Test-Path $defaultPomFilePath)) {
2020
Copy-Item $bomPomFilePath -Destination $inputDir
2121
}
2222

23-
$mvnResults = mvn install
24-
$mvnResults = "mvn exec:java -Dexec.args=`"-inputDir=$inputDir -outputDir=$outputDir -mode=generate`""
23+
echo "Run the following to generate the Pom file and dependency closure report. Both files will be generated in the outputDir."
24+
echo "mvn exec:java -Dexec.args=`"-inputDir=$inputDir -outputDir=$outputDir -mode=generate`""

eng/bomgenerator/report.log

Whitespace-only changes.

eng/bomgenerator/src/main/java/com/azure/tools/bomgenerator/BomGenerator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,9 @@ private void writeBom(Collection<BomDependency> bomDependencies) {
336336
}).collect(Collectors.toList());
337337
dependencies.addAll(externalBomDependencies);
338338
dependencies.sort(new DependencyComparator());
339+
340+
// Remove external dependencies from the BOM.
341+
dependencies = dependencies.stream().filter(dependency -> BASE_AZURE_GROUPID.equals(dependency.getGroupId())).collect(Collectors.toList());
339342
management.setDependencies(dependencies);
340343
writeModel(this.pomFileName, this.outputFileName, model);
341344
}

sdk/boms/azure-sdk-bom/CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
11
# Release History
22

3+
## 1.1.0 (2021-01-22)
4+
5+
### Dependency Updates
6+
7+
- Updated Azure SDK dependency versions to more recent releases.
8+
- Removed non-Azure SDK dependencies from the Azure SDK BOM.
9+
Azure SDK BOM used to include external dependencies till now however this let to [dependency conflicts](https://github.com/Azure/azure-sdk-for-java/issues/26217)
10+
in situations where our libraries were used along side other frameworks. Given the above we are removing 3rd party dependencies from the BOM and letting the Azure SDK Client implementation libraries bring them in at runtime.
11+
We continue to ensure all our client libraries have unified set of external dependencies to prevents conflicts when used together.
12+
13+
#### Breaking Changes
14+
If you depend on Azure SDK BOM to get versions for external libraries you would now see compilation errors in your project. Please explicitly add the required versions of your external dependencies to your project POM files.
15+
Depending on implicit version for transitive dependencies should be avoided as it is not a recommended practice.
16+
317
## 1.0.6 (2021-11-22)
418

519
### Dependency Updates

0 commit comments

Comments
 (0)