{storage-preview} Remove az storage blob service-properties command group (Azure#3244)

Author: Juliehzl

src/storage-preview/HISTORY.rst

@@ -2,6 +2,10 @@
 
 Release History
 ===============
+0.7.2(2021-04-09)
+++++++++++++++++++
+* Remove `az storage blob service-properties` as it is supported in storage-blob-preview extension and Azure CLI
+
 0.7.1(2021-04-06)
 ++++++++++++++++++
 * `az storage account file-service-properties`: Add support for secured SMB

src/storage-preview/azext_storage_preview/azext_metadata.json

@@ -1,4 +1,4 @@
 {
-    "azext.minCliCoreVersion": "2.13.0",
+    "azext.minCliCoreVersion": "2.21.0",
     "azext.isPreview": true
 }

src/storage-preview/azext_storage_preview/commands.py

@@ -94,18 +94,6 @@ def get_custom_sdk(custom_module, client_factory, resource_type=CUSTOM_DATA_STOR
         g.custom_command('list', 'list_network_rules')
         g.custom_command('remove', 'remove_network_rule')
 
-    base_blob_sdk = CliCommandType(
-        operations_tmpl='azext_storage_preview.vendored_sdks.azure_storage.blob.baseblobservice#BaseBlobService.{}',
-        client_factory=blob_data_service_factory,
-        resource_type=CUSTOM_DATA_STORAGE)
-
-    with self.command_group('storage blob service-properties', command_type=base_blob_sdk) as g:
-        g.storage_command_oauth('show', 'get_blob_service_properties', exception_handler=show_exception_handler)
-        g.storage_command_oauth('update', generic_update=True, getter_name='get_blob_service_properties',
-                                setter_type=get_custom_sdk('blob', cf_blob_data_gen_update),
-                                setter_name='set_service_properties',
-                                client_factory=cf_blob_data_gen_update)
-
     block_blob_sdk = CliCommandType(
         operations_tmpl='azure.multiapi.storage.blob.blockblobservice#BlockBlobService.{}',
         client_factory=blob_data_service_factory,

src/storage-preview/azext_storage_preview/operations/blob.py

@@ -6,43 +6,11 @@
 from __future__ import print_function
 
 from urllib.parse import quote
-from knack.util import CLIError
 from knack.log import get_logger
 
 logger = get_logger(__name__)
 
 
-def set_service_properties(client, parameters, delete_retention=None, days_retained=None, static_website=None,
-                           index_document=None, error_document_404_path=None):
-    # update
-    kwargs = {}
-    if any([delete_retention, days_retained]):
-        kwargs['delete_retention_policy'] = parameters.delete_retention_policy
-    if delete_retention is not None:
-        parameters.delete_retention_policy.enabled = delete_retention
-    if days_retained is not None:
-        parameters.delete_retention_policy.days = days_retained
-
-    if any([static_website, index_document, error_document_404_path]):
-        if getattr(parameters, 'static_website', None) is None:
-            raise CLIError('Static websites are only supported for StorageV2 (general-purpose v2) accounts.')
-        kwargs['static_website'] = parameters.static_website
-    if static_website is not None:
-        parameters.static_website.enabled = static_website
-    if index_document is not None:
-        parameters.static_website.index_document = index_document
-    if error_document_404_path is not None:
-        parameters.static_website.error_document_404_path = error_document_404_path
-
-    # checks
-    policy = parameters.delete_retention_policy
-    if policy.enabled and not policy.days:
-        raise CLIError("must specify days-retained")
-
-    client.set_blob_service_properties(**kwargs)
-    return client.get_blob_service_properties()
-
-
 def show_directory(client, container_name, directory_name, snapshot=None, lease_id=None,
                    if_modified_since=None, if_unmodified_since=None, if_match=None,
                    if_none_match=None, timeout=None):

src/storage-preview/azext_storage_preview/tests/latest/test_storage_blob_scenarios.py

@@ -8,7 +8,7 @@
 from codecs import open
 from setuptools import setup, find_packages
 
-VERSION = "0.7.1"
+VERSION = "0.7.2"
 
 CLASSIFIERS = [
     'Development Status :: 4 - Beta',