chore: helm chart should create storage class #109
Conversation
|
Do we need to cleanup creation of this storageclass in tests? It matches so there is no conflict for now |
Yes, good idea. I'm also reconsidering whether we should create the StorageClass by default? |
| @@ -0,0 +1,10 @@ | |||
| {{- if .Values.storageClass.enabled }} | |||
There was a problem hiding this comment.
You may need this check https://github.com/kaito-project/kaito/blob/main/charts/kaito/workspace/templates/local-csi-storageclass.yaml#L3
to make it idempotent.
I meet an issue when rollback the helm.
'Error: cannot patch kaito-local-nvme-disk with kind StorageClass: StorageClass.storage.k8s.io kaito-local-nvme-disk is invalid: parameters: Forbidden: updates to parameters are forbidden.'
| # should be created manually or by another tool. | ||
| enabled: true | ||
| # The name of the storage class. | ||
| name: "local" |
There was a problem hiding this comment.
suggest local-csi as local is very generic,
and could easily be interpreted/conflict w/ a storage class for kubernetes-native local volumes (https://kubernetes.io/docs/concepts/storage/storage-classes/#local)
|
Closing until we decide we really want this. |
Helm chart will now install the StorageClass by default. Can be disabled using
--values storageClass.enabled=false.