Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Multicore JIT for faster Bicep startup times #2804

Closed
stan-sz opened this issue May 24, 2021 · 4 comments · Fixed by #3112
Closed

Use Multicore JIT for faster Bicep startup times #2804

stan-sz opened this issue May 24, 2021 · 4 comments · Fixed by #3112
Labels
enhancement New feature or request
Milestone

Comments

@stan-sz
Copy link
Contributor

stan-sz commented May 24, 2021

Is your feature request related to a problem? Please describe.
Bicep no longer accepts multiple files in a single command and requires to re-invoke the app in the shell multiple times (related to #1285).

Describe the solution you'd like
Bicep's startup times can potentially be improved by using https://docs.microsoft.com/en-us/dotnet/api/system.runtime.profileoptimization?view=net-5.0 (e.g. roslyn). This might also help the Bicep Lang server for VS code extension.

@stan-sz stan-sz added the enhancement New feature or request label May 24, 2021
@ghost ghost added the Needs: Triage 🔍 label May 24, 2021
@anthony-c-martin
Copy link
Member

Interesting, thanks for the info!

@majastrz
Copy link
Member

Indeed. We should benchmark and see how much it helps.

@alex-frankel alex-frankel added this to the v0.5 milestone May 27, 2021
@stan-sz
Copy link
Contributor Author

stan-sz commented Jun 8, 2021

Building the examples in the repo using this command and a locally-built Bicep in Release:

github\bicep\docs\examples [main ≡]> measure-command { gci -Recurse *.bicep | %{ ..\..\src\Bicep.Cli\bin\Release\net5.0\bicep.exe build $_  } }

I got these numbers for three consecutive runs:

With multicore JIT:

TotalSeconds : 97.9127821
TotalSeconds : 101.3656751
TotalSeconds : 97.3832298

Current main branch version:

TotalSeconds : 151.3699426
TotalSeconds : 154.0155866
TotalSeconds : 152.55113

stan-sz added a commit to stan-sz/bicep that referenced this issue Jun 8, 2021
@stan-sz stan-sz mentioned this issue Jun 8, 2021
14 tasks
@majastrz
Copy link
Member

That's a nice improvement!

@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants