linter should catch non-optimal scope references

[alex-frankel]

If you don't have a proper reference to a resource group (or other scope), you can provide a scope using the relevant scope function:

module foo '...' = {
  scope: resourceGroup('my-rg')
  ...
}

However, if you do have a reference, it is better to use that reference directly. This is a newer capability so there are old examples out there that use the previous way we exposed.

This is ideal if you have a reference:

resource rg 'microsoft.resources/resourceGroups@2020-06-01' = { ... }

module foo '...' = {
  scope: rg
  ...
}

But in practice we often see this less ideal pattern:

resource rg 'microsoft.resources/resourceGroups@2020-06-01' = { ... }

module foo '...' = {
  scope: resourceGroup(rg.name)
  ...
}

[majastrz]

It should work for MGs this way as well once we fix #1833.

[alex-frankel]

If possible, it would be great to catch this scenario as well, where the rgName param is used for the RG declaration and the scope for the module:

targetScope = 'subscription'

param rgName string

resource rg 'Microsoft.Resources/resourceGroups@2021-04-01' = {
  name: rgName
  location: deployment().location
}

module foo 'appPlan.bicep' = {
  scope: resourceGroup(rgName)
}