-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of 'new' command #1851
Conversation
…ustom repository. Downloads single chosen template file and displays it or stores it to the file system.
Codecov Report
@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 95.11% 95.03% -0.08%
==========================================
Files 371 376 +5
Lines 21888 22500 +612
Branches 15 15
==========================================
+ Hits 20818 21383 +565
- Misses 1070 1117 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey @antsok - thanks for submitting this PR. We want to have a discussion on our side before we give more feedback to you. Basically, our concern is that this command is making http calls which is a net-new capability for the bicep CLI which we have some reservations about. Wanted to give you this update so you know we are not missing this. Going forward, if you want to submit any other PRs, we ask that you comment on (or create) a relevant issue to make sure the design of the implementation has been reviewed in some capacity prior to beginning any work (per our contribution guide). I know you submitted an issue, but we would have liked to see an indication that you were going to work on it as well as what the implementation was going to look like. This is so that you don't spend any time on something that may not meet our expectations. In full transparency, we may not be able to accept this PR, but I hope this does not deter you from submitting other PRs in the future! Let me know if there's anything above I can further clarify. |
Hi @alex-frankel and the team, Thank you for your constructive feedback. I should have paid more attention to the rules of contributing. |
As mentioned earlier, we are going to close this one mainly due to the introduction of HTTP requests. If we still want a "new" command, let's start with what you currently have for |
Fixes #1750
For initial review.
Unit tests added.