Skip to content

Update client and models based on new typespec version (2024-10-01) #40137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Jun 10, 2025

Conversation

koen-mertens
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 19, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-healthinsights-radiologyinsights

@koen-mertens koen-mertens marked this pull request as ready for review June 1, 2025 20:34
@Copilot Copilot AI review requested due to automatic review settings June 1, 2025 20:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SDK client and model code to incorporate the new typespec version (2024-10-01) while also enhancing type hints, import organization, and documentation including new inference samples for guidance, quality measure, and scoring & assessment.

  • Updated default API version strings from "2024-04-01" to "2024-10-01" in configuration and client files.
  • Refactored imports and adjusted type hints in several files (both async and sync) to improve code clarity.
  • Expanded README and apiview-properties to include new inference types and samples, with corresponding version bumps in _version.py and CHANGELOG.md.

Reviewed Changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
azure/healthinsights/radiologyinsights/aio/_operations/init.py Minor import reordering and adds TYPE_CHECKING based conditional imports.
azure/healthinsights/radiologyinsights/aio/_configuration.py Updates default API version from "2024-04-01" to "2024-10-01".
azure/healthinsights/radiologyinsights/aio/_client.py Updates docstrings and API version string; removes extra pylint disables.
azure/healthinsights/radiologyinsights/_serialization.py Adjusts docstrings and type hints; improves exception docs and fixes minor typos.
azure/healthinsights/radiologyinsights/_operations/_operations.py Updates API version and error handling with _failsafe_deserialize improvements.
azure/healthinsights/radiologyinsights/_model_base.py Enhances type hints and documentation; updates new and subclass handling.
README.md Adds new inference sample code for Guidance, Quality Measure, and Scoring & Assessment.
CHANGELOG.md Updates version history and highlights additions of new inference samples.
apiview-properties.json Updates cross-language mapping for newly added inference types.
.vscode/cspell.json Adds new technical words to the spell-check dictionary.
Comments suppressed due to low confidence (1)

sdk/healthinsights/azure-healthinsights-radiologyinsights/_serialization.py:1167

  • The word 'serialied' appears to be a typo. It should be corrected to 'serialized'.
         :return: serialied unix

@koen-mertens koen-mertens merged commit 1d66356 into Azure:main Jun 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants