Removing validations from Recording APIs (#21427)

* Removing URL validation

* Removing validations for recording apis

* Removing bad comments

Author: cochi2

sdk/communication/azure-communication-callingserver/azure/communication/callingserver/_callingserver_client.py

@@ -621,11 +621,6 @@ def start_recording( # pylint: disable=too-many-arguments
         **kwargs  # type: Any
     ):  # type: (...) -> StartCallRecordingResult
 
-        if not call_locator:
-            raise ValueError("call_locator cannot be None")
-        if not CallingServerUtils.is_valid_url(recording_state_callback_uri):
-            raise ValueError("recording_state_callback_uri is invalid")
-
         start_call_recording_with_calllocator_request = StartCallRecordingWithCallLocatorRequest(
             call_locator=serialize_call_locator(call_locator),
             recording_state_callback_uri=recording_state_callback_uri,
@@ -647,9 +642,6 @@ def pause_recording(
         **kwargs  # type: Any
     ):  # type: (...) -> HttpResponse
 
-        if not recording_id:
-            raise ValueError("recording_id cannot be None")
-
         return self._server_call_client.pause_recording(
             recording_id=recording_id,
             **kwargs
@@ -662,9 +654,6 @@ def resume_recording(
         **kwargs  # type: Any
     ):  # type: (...) -> HttpResponse
 
-        if not recording_id:
-            raise ValueError("recording_id cannot be None")
-
         return self._server_call_client.resume_recording(
             recording_id=recording_id,
             **kwargs
@@ -677,9 +666,6 @@ def stop_recording(
         **kwargs  # type: Any
     ):  # type: (...) -> HttpResponse
 
-        if not recording_id:
-            raise ValueError("recording_id cannot be None")
-
         return self._server_call_client.stop_recording(
             recording_id=recording_id,
             **kwargs
@@ -692,9 +678,6 @@ def get_recording_properities(
         **kwargs  # type: Any
     ):  # type: (...) -> CallRecordingProperties
 
-        if not recording_id:
-            raise ValueError("recording_id cannot be None")
-
         return self._server_call_client.get_recording_properties(
             recording_id=recording_id,
             **kwargs

sdk/communication/azure-communication-callingserver/azure/communication/callingserver/_download.py

@@ -321,8 +321,6 @@ def readinto(self, stream):
             try:
                 stream.seek(stream.tell())
             except (NotImplementedError, AttributeError):
-                # https://stackoverflow.com/questions/27318327/how-to-imitate-python-3s-raise-from-in-python-2
-                # https://stackoverflow.com/questions/34463087/valid-syntax-in-both-python-2-x-and-3-x-for-raising-exception/40877934
                 traceback = sys.exc_info()[2]
                 raise_(ValueError, error_message, traceback)
 

sdk/communication/azure-communication-callingserver/azure/communication/callingserver/aio/_callingserver_client_async.py

@@ -625,11 +625,6 @@ async def start_recording( # pylint: disable=too-many-arguments
         **kwargs: Any
     ) -> StartCallRecordingResult:
 
-        if not call_locator:
-            raise ValueError("call_locator cannot be None")
-        if not CallingServerUtils.is_valid_url(recording_state_callback_uri):
-            raise ValueError("recording_state_callback_uri is invalid")
-
         start_call_recording_request = StartCallRecordingWithCallLocatorRequest(
             call_locator=serialize_call_locator(call_locator),
             recording_state_callback_uri=recording_state_callback_uri,