update tests

Author: g2vinay

sdk/identity/azure-identity/src/main/java/com/azure/identity/DefaultAzureCredentialBuilder.java

@@ -18,8 +18,6 @@
 import java.util.Objects;
 import java.util.concurrent.ExecutorService;
 
-
-
 /**
  * <p>Fluent credential builder for instantiating {@link DefaultAzureCredential}.</p>
  *
@@ -343,7 +341,6 @@ private void addDevCredentials(List<TokenCredential> credentials) {
         credentials.add(new OSBrokerCredential(tenantId));
     }
 
-
     private WorkloadIdentityCredential getWorkloadIdentityCredential() {
         Configuration configuration = identityClientOptions.getConfiguration() == null
             ? Configuration.getGlobalConfiguration().clone()

sdk/identity/azure-identity/src/main/java/com/azure/identity/OSBrokerCredential.java

@@ -15,7 +15,8 @@
 
 class OSBrokerCredential implements TokenCredential {
     private static final ClientLogger LOGGER = new ClientLogger(OSBrokerCredential.class);
-    private static final String BROKER_BUILDER_CLASS = "com.azure.identity.broker.InteractiveBrowserBrokerCredentialBuilder";
+    private static final String BROKER_BUILDER_CLASS
+        = "com.azure.identity.broker.InteractiveBrowserBrokerCredentialBuilder";
     private final String tenantId;
     private final AtomicReference<TokenCredential> cached = new AtomicReference<>();
 
@@ -38,11 +39,12 @@ public Mono<AccessToken> getToken(TokenRequestContext request) {
     }
 
     private TokenCredential createBrokerCredential() {
-        final String troubleshoot = " To mitigate this issue, refer to http://aka.ms/azsdk/java/identity/dacbrokerauth/troubleshoot";
+        final String troubleshoot
+            = " To mitigate this issue, refer to http://aka.ms/azsdk/java/identity/dacbrokerauth/troubleshoot";
         if (!IdentityUtil.isBrokerAvailable()) {
             throw LOGGER.logExceptionAsError(
                 new CredentialUnavailableException("azure-identity-broker dependency is not available. "
-                + "Ensure you have azure-identity-broker dependency added to your application." + troubleshoot));
+                    + "Ensure you have azure-identity-broker dependency added to your application." + troubleshoot));
         }
         try {
             Class<?> builderClass = Class.forName(BROKER_BUILDER_CLASS);
@@ -56,12 +58,14 @@ private TokenCredential createBrokerCredential() {
             }
             return browserCredentialBuilder.build();
         } catch (ClassNotFoundException e) {
-            throw LOGGER.logExceptionAsError(
-                new CredentialUnavailableException("InteractiveBrowserBrokerCredentialBuilder class not found. "
-                + "Ensure you have azure-identity-broker dependency added to your application." + troubleshoot, e));
+            throw LOGGER
+                .logExceptionAsError(new CredentialUnavailableException(
+                    "InteractiveBrowserBrokerCredentialBuilder class not found. "
+                        + "Ensure you have azure-identity-broker dependency added to your application." + troubleshoot,
+                    e));
         } catch (Exception e) {
-            throw LOGGER.logExceptionAsError(
-                new CredentialUnavailableException("Failed to create InteractiveBrowserBrokerCredential dynamically." + troubleshoot, e));
+            throw LOGGER.logExceptionAsError(new CredentialUnavailableException(
+                "Failed to create InteractiveBrowserBrokerCredential dynamically." + troubleshoot, e));
         }
     }
 }

sdk/identity/azure-identity/src/test/java/com/azure/identity/DacOsBrokerCredentialTest.java

@@ -11,15 +11,17 @@ public class DacOsBrokerCredentialTest {
     @Test
     public void testBrokerUnavailable() {
         // setup
-        TokenRequestContext request = new TokenRequestContext()
-            .addScopes("https://vault.azure.net/.default").setTenantId("newTenant");
+        TokenRequestContext request
+            = new TokenRequestContext().addScopes("https://vault.azure.net/.default").setTenantId("newTenant");
 
         // Simulate broker unavailable by using a test double or by ensuring the environment does not support broker
         OSBrokerCredential credential = new OSBrokerCredential("tenant");
         StepVerifier.create(credential.getToken(request))
             .expectErrorMatches(e -> e instanceof CredentialUnavailableException
                 && e.getMessage().contains("azure-identity-broker dependency is not available")
-                && e.getMessage().contains("To mitigate this issue, refer to http://aka.ms/azsdk/java/identity/dacbrokerauth/troubleshoot"))
+                && e.getMessage()
+                    .contains(
+                        "To mitigate this issue, refer to http://aka.ms/azsdk/java/identity/dacbrokerauth/troubleshoot"))
             .verify();
     }
 }

sdk/identity/azure-identity/src/test/java/com/azure/identity/DefaultAzureCredentialTest.java

@@ -659,14 +659,15 @@ public void testDeveloperOnlyCredentialsChain(String devValue) {
         List<TokenCredential> credentials = extractCredentials(credential);
 
         // Only developer credentials should be present (4)
-        assertEquals(5, credentials.size());
+        assertEquals(6, credentials.size());
 
         // Verify developer credentials in order
         assertInstanceOf(IntelliJCredential.class, credentials.get(0));
         assertInstanceOf(VisualStudioCodeCredential.class, credentials.get(1));
         assertInstanceOf(AzureCliCredential.class, credentials.get(2));
         assertInstanceOf(AzurePowerShellCredential.class, credentials.get(3));
         assertInstanceOf(AzureDeveloperCliCredential.class, credentials.get(4));
+        assertInstanceOf(OSBrokerCredential.class, credentials.get(5));
     }
 
     @ParameterizedTest
@@ -772,8 +773,8 @@ public void testDefaultCredentialChainWithoutFilter() {
         // Extract credentials to check their types and order
         List<TokenCredential> credentials = extractCredentials(credential);
 
-        // Verify the complete chain with all 7 credentials
-        assertEquals(8, credentials.size());
+        // Verify the complete chain with all 9 credentials
+        assertEquals(9, credentials.size());
         assertInstanceOf(EnvironmentCredential.class, credentials.get(0));
         assertInstanceOf(WorkloadIdentityCredential.class, credentials.get(1));
         assertInstanceOf(ManagedIdentityCredential.class, credentials.get(2));
@@ -782,6 +783,7 @@ public void testDefaultCredentialChainWithoutFilter() {
         assertInstanceOf(AzureCliCredential.class, credentials.get(5));
         assertInstanceOf(AzurePowerShellCredential.class, credentials.get(6));
         assertInstanceOf(AzureDeveloperCliCredential.class, credentials.get(7));
+        assertInstanceOf(OSBrokerCredential.class, credentials.get(8));
     }
 
     /**